-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: migrate angular e2e app to ng cli #974
chore: migrate angular e2e app to ng cli #974
Conversation
📦 Bundlesize report
|
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪 |
948b19a
to
5429db6
Compare
4358c28
to
28f2d59
Compare
724c7c4
to
cbbef01
Compare
@@ -1,6 +1,6 @@ | |||
{ | |||
"extends": "./tsconfig.lib.json", | |||
"angularCompilerOptions": { | |||
"enableIvy": true | |||
"enableIvy": false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Publishing fails when ivy is set to true. The recommendation from Angular team is to publish the libraries by keeping enableIvy as false
and Applications using the library can opt in to ivy mode by using Angular Compatibility Compiler (ngcc). More details here https://next.angular.io/guide/creating-libraries#publishing-your-library
748e76e
to
f1a2fcc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @vigneshshanmugam ,
Generally looks good, however, there are a few warnings in the main build script and also in e2e build
I'm also going to run it locally.
@jahtalab I have added fix for some of the warnings.
For this to get fixed, we have to change to |
* chore: migrate angular e2e app to ng cli * chore: make build system work for e2e * chore: make saucelabs work * chore: enable saucelabs test for angular * chore: fix test scripts * chore: target es5 and add browserlist * chore: only run saucelabs test in jenkins * chore: update prod apmserver url * chore: transpile apmservermock correctly * chore: revert jenkinsfile * chore: fix warnings in build
@vigneshshanmugam , there's also a warning about naming (I don't have the exact message since the logs are no longer accessible) |
@jahtalab Fixing it with the next PR - https://github.com/vigneshshanmugam/apm-agent-js-base/blob/4be1c2f5240c5740f01e2794b86105dbbbe9f065/packages/rum-angular/ng-package.json. Waiting for the prettier to get merged. |
* chore: migrate angular e2e app to ng cli * chore: make build system work for e2e * chore: make saucelabs work * chore: enable saucelabs test for angular * chore: fix test scripts * chore: target es5 and add browserlist * chore: only run saucelabs test in jenkins * chore: update prod apmserver url * chore: transpile apmservermock correctly * chore: revert jenkinsfile * chore: fix warnings in build
* chore: migrate angular e2e app to ng cli * chore: make build system work for e2e * chore: make saucelabs work * chore: enable saucelabs test for angular * chore: fix test scripts * chore: target es5 and add browserlist * chore: only run saucelabs test in jenkins * chore: update prod apmserver url * chore: transpile apmservermock correctly * chore: revert jenkinsfile * chore: fix warnings in build
* chore: migrate angular e2e app to ng cli * chore: make build system work for e2e * chore: make saucelabs work * chore: enable saucelabs test for angular * chore: fix test scripts * chore: target es5 and add browserlist * chore: only run saucelabs test in jenkins * chore: update prod apmserver url * chore: transpile apmservermock correctly * chore: revert jenkinsfile * chore: fix warnings in build
* chore: migrate angular e2e app to ng cli * chore: make build system work for e2e * chore: make saucelabs work * chore: enable saucelabs test for angular * chore: fix test scripts * chore: target es5 and add browserlist * chore: only run saucelabs test in jenkins * chore: update prod apmserver url * chore: transpile apmservermock correctly * chore: revert jenkinsfile * chore: fix warnings in build
* chore: migrate angular e2e app to ng cli * chore: make build system work for e2e * chore: make saucelabs work * chore: enable saucelabs test for angular * chore: fix test scripts * chore: target es5 and add browserlist * chore: only run saucelabs test in jenkins * chore: update prod apmserver url * chore: transpile apmservermock correctly * chore: revert jenkinsfile * chore: fix warnings in build
* chore: migrate angular e2e app to ng cli * chore: make build system work for e2e * chore: make saucelabs work * chore: enable saucelabs test for angular * chore: fix test scripts * chore: target es5 and add browserlist * chore: only run saucelabs test in jenkins * chore: update prod apmserver url * chore: transpile apmservermock correctly * chore: revert jenkinsfile * chore: fix warnings in build
* feat(rum-angular)!: angular 9-11 support (#971) * feat(rum-angular): add support for angular 9 * chore: set up the ng build toolchain * chore: rewrite the apm module under src/* * chore: set up the testing with ng * chore: make karma:dev work * chore: make karma:coverage work * chore: address review and disable saucelabs * chore: fix local link and coverage test * chore: migrate angular e2e app to ng cli (#974) * chore: migrate angular e2e app to ng cli * chore: make build system work for e2e * chore: make saucelabs work * chore: enable saucelabs test for angular * chore: fix test scripts * chore: target es5 and add browserlist * chore: only run saucelabs test in jenkins * chore: update prod apmserver url * chore: transpile apmservermock correctly * chore: revert jenkinsfile * chore: fix warnings in build * chore(rum-angular): fix build warnings in prod * chore(rum-angular): add prepublish command * chore(release): publish angular - @elastic/apm-rum-angular@2.0.0-alpha.0 * chore(release): publish angular - @elastic/apm-rum-angular@2.0.0-alpha.1 * docs: update angular integration for >9 versions (#1000) * chore: update angular to latest 11.2.5 (#996) * chore(release): publish angular - @elastic/apm-rum-angular@2.0.0-alpha.2 * chore: fix license lint issue
* feat(rum-angular)!: angular 9-11 support (elastic#971) * feat(rum-angular): add support for angular 9 * chore: set up the ng build toolchain * chore: rewrite the apm module under src/* * chore: set up the testing with ng * chore: make karma:dev work * chore: make karma:coverage work * chore: address review and disable saucelabs * chore: fix local link and coverage test * chore: migrate angular e2e app to ng cli (elastic#974) * chore: migrate angular e2e app to ng cli * chore: make build system work for e2e * chore: make saucelabs work * chore: enable saucelabs test for angular * chore: fix test scripts * chore: target es5 and add browserlist * chore: only run saucelabs test in jenkins * chore: update prod apmserver url * chore: transpile apmservermock correctly * chore: revert jenkinsfile * chore: fix warnings in build * chore(rum-angular): fix build warnings in prod * chore(rum-angular): add prepublish command * chore(release): publish angular - @elastic/apm-rum-angular@2.0.0-alpha.0 * chore(release): publish angular - @elastic/apm-rum-angular@2.0.0-alpha.1 * docs: update angular integration for >9 versions (elastic#1000) * chore: update angular to latest 11.2.5 (elastic#996) * chore(release): publish angular - @elastic/apm-rum-angular@2.0.0-alpha.2 * chore: fix license lint issue
ng
CLI and packager.test/e2e/build
and then tests are ran to make sure our existing e2e test setup works and alsong serve
works for local development.If you want to run the E2E app in local, you can try out using
ng serve app
which would run the build command and watch your files for local changes.