chore: migrate angular e2e app to ng cli #974

vigneshshanmugam · 2021-03-06T00:27:20Z

fix add e2e tests for rum-angular using angular cli #450
Follow up of Add support for Angular 9, 10 and 11 #962
Moves the E2E app to the Angular build system using ng CLI and packager.
The build for E2E app is moved under test/e2e/build and then tests are ran to make sure our existing e2e test setup works and also ng serve works for local development.

If you want to run the E2E app in local, you can try out using ng serve app which would run the build command and watch your files for local changes.

apmmachine · 2021-03-06T01:44:01Z

📦 Bundlesize report

Filename	Size(bundled)	Size(gzip)	Diff(gzip)
elastic-apm-opentracing.umd.min.js	62.2 KiB	19.8 KiB
elastic-apm-rum.umd.min.js	56.3 KiB	18.4 KiB

apmmachine · 2021-03-06T01:44:03Z

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Build Cause: Pull request #974 updated
Start Time: 2021-03-10T16:00:17.935+0000
Duration: 94 min 58 sec
Commit: 66a8359

Test stats 🧪

Test	Results
Failed	0
Passed	1037
Skipped	13
Total	1050

Trends 🧪

vigneshshanmugam · 2021-03-09T06:25:20Z

packages/rum-angular/tsconfig.lib.prod.json

@@ -1,6 +1,6 @@
 {
  "extends": "./tsconfig.lib.json",
  "angularCompilerOptions": {
-    "enableIvy": true
+    "enableIvy": false


Publishing fails when ivy is set to true. The recommendation from Angular team is to publish the libraries by keeping enableIvy as false and Applications using the library can opt in to ivy mode by using Angular Compatibility Compiler (ngcc). More details here https://next.angular.io/guide/creating-libraries#publishing-your-library

packages/rum-angular/test/e2e/with-router/app.e2e-spec.js

hmdhk

Thanks @vigneshshanmugam ,

Generally looks good, however, there are a few warnings in the main build script and also in e2e build

I'm also going to run it locally.

packages/rum-angular/package.json

packages/rum-angular/angular.json

vigneshshanmugam · 2021-03-10T16:03:57Z

@jahtalab I have added fix for some of the warnings.

WARNING: 'NavigationStart' is imported from external module '@angular/router' but never used

For this to get fixed, we have to change to import type { NavigationStart } from '@angular/router' -> need to update typescript to 3.8 -> need to update prettier to 2.0 to understand the syntax which breaks the formatting locally. I will do a follow up PR to change the Eslint and prettier configs to get these sorted out.

vigneshshanmugam · 2021-03-11T19:08:01Z

@jahtalab I am merging this to our feat-angular branch. Lets fix the NavigationStart warning in the other PR #978

* chore: migrate angular e2e app to ng cli * chore: make build system work for e2e * chore: make saucelabs work * chore: enable saucelabs test for angular * chore: fix test scripts * chore: target es5 and add browserlist * chore: only run saucelabs test in jenkins * chore: update prod apmserver url * chore: transpile apmservermock correctly * chore: revert jenkinsfile * chore: fix warnings in build

hmdhk · 2021-03-15T08:47:15Z

@vigneshshanmugam , there's also a warning about naming (I don't have the exact message since the logs are no longer accessible)

vigneshshanmugam · 2021-03-15T14:15:58Z

@jahtalab Fixing it with the next PR - https://github.com/vigneshshanmugam/apm-agent-js-base/blob/4be1c2f5240c5740f01e2794b86105dbbbe9f065/packages/rum-angular/ng-package.json. Waiting for the prettier to get merged.

* chore: migrate angular e2e app to ng cli * chore: make build system work for e2e * chore: make saucelabs work * chore: enable saucelabs test for angular * chore: fix test scripts * chore: target es5 and add browserlist * chore: only run saucelabs test in jenkins * chore: update prod apmserver url * chore: transpile apmservermock correctly * chore: revert jenkinsfile * chore: fix warnings in build

* feat(rum-angular)!: angular 9-11 support (#971) * feat(rum-angular): add support for angular 9 * chore: set up the ng build toolchain * chore: rewrite the apm module under src/* * chore: set up the testing with ng * chore: make karma:dev work * chore: make karma:coverage work * chore: address review and disable saucelabs * chore: fix local link and coverage test * chore: migrate angular e2e app to ng cli (#974) * chore: migrate angular e2e app to ng cli * chore: make build system work for e2e * chore: make saucelabs work * chore: enable saucelabs test for angular * chore: fix test scripts * chore: target es5 and add browserlist * chore: only run saucelabs test in jenkins * chore: update prod apmserver url * chore: transpile apmservermock correctly * chore: revert jenkinsfile * chore: fix warnings in build * chore(rum-angular): fix build warnings in prod * chore(rum-angular): add prepublish command * chore(release): publish angular - @elastic/apm-rum-angular@2.0.0-alpha.0 * chore(release): publish angular - @elastic/apm-rum-angular@2.0.0-alpha.1 * docs: update angular integration for >9 versions (#1000) * chore: update angular to latest 11.2.5 (#996) * chore(release): publish angular - @elastic/apm-rum-angular@2.0.0-alpha.2 * chore: fix license lint issue

* feat(rum-angular)!: angular 9-11 support (elastic#971) * feat(rum-angular): add support for angular 9 * chore: set up the ng build toolchain * chore: rewrite the apm module under src/* * chore: set up the testing with ng * chore: make karma:dev work * chore: make karma:coverage work * chore: address review and disable saucelabs * chore: fix local link and coverage test * chore: migrate angular e2e app to ng cli (elastic#974) * chore: migrate angular e2e app to ng cli * chore: make build system work for e2e * chore: make saucelabs work * chore: enable saucelabs test for angular * chore: fix test scripts * chore: target es5 and add browserlist * chore: only run saucelabs test in jenkins * chore: update prod apmserver url * chore: transpile apmservermock correctly * chore: revert jenkinsfile * chore: fix warnings in build * chore(rum-angular): fix build warnings in prod * chore(rum-angular): add prepublish command * chore(release): publish angular - @elastic/apm-rum-angular@2.0.0-alpha.0 * chore(release): publish angular - @elastic/apm-rum-angular@2.0.0-alpha.1 * docs: update angular integration for >9 versions (elastic#1000) * chore: update angular to latest 11.2.5 (elastic#996) * chore(release): publish angular - @elastic/apm-rum-angular@2.0.0-alpha.2 * chore: fix license lint issue

vigneshshanmugam mentioned this pull request Mar 6, 2021

BREAKING CHANGE(rum-angular): add support for angular 9 #971

Merged

3 tasks

vigneshshanmugam changed the base branch from master to feat-angular March 8, 2021 17:33

vigneshshanmugam added 4 commits March 8, 2021 11:35

chore: migrate angular e2e app to ng cli

e165151

chore: make build system work for e2e

2117699

chore: make saucelabs work

ce6f8d0

chore: enable saucelabs test for angular

5429db6

vigneshshanmugam force-pushed the angular-e2e branch from 948b19a to 5429db6 Compare March 8, 2021 19:35

vigneshshanmugam marked this pull request as ready for review March 8, 2021 19:55

chore: fix test scripts

28f2d59

vigneshshanmugam force-pushed the angular-e2e branch from 4358c28 to 28f2d59 Compare March 8, 2021 22:24

vigneshshanmugam added 2 commits March 8, 2021 16:40

chore: target es5 and add browserlist

efe083f

chore: only run saucelabs test in jenkins

cbbef01

vigneshshanmugam force-pushed the angular-e2e branch from 724c7c4 to cbbef01 Compare March 9, 2021 02:25

chore: update prod apmserver url

8fcb84d

vigneshshanmugam commented Mar 9, 2021

View reviewed changes

packages/rum-angular/test/e2e/with-router/app.e2e-spec.js Show resolved Hide resolved

vigneshshanmugam added 2 commits March 8, 2021 22:33

chore: transpile apmservermock correctly

c692b29

chore: revert jenkinsfile

f1a2fcc

vigneshshanmugam force-pushed the angular-e2e branch from 748e76e to f1a2fcc Compare March 9, 2021 06:38

vigneshshanmugam requested a review from hmdhk March 9, 2021 06:38

hmdhk reviewed Mar 10, 2021

View reviewed changes

packages/rum-angular/package.json Show resolved Hide resolved

packages/rum-angular/angular.json Show resolved Hide resolved

chore: fix warnings in build

66a8359

vigneshshanmugam mentioned this pull request Mar 10, 2021

chore(rum-angular): fix build warning and formatting #978

Closed

vigneshshanmugam merged commit afbc68d into elastic:feat-angular Mar 11, 2021

vigneshshanmugam deleted the angular-e2e branch March 11, 2021 19:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: migrate angular e2e app to ng cli #974

chore: migrate angular e2e app to ng cli #974

vigneshshanmugam commented Mar 6, 2021 •

edited

Loading

apmmachine commented Mar 6, 2021 •

edited

Loading

apmmachine commented Mar 6, 2021 •

edited

Loading

Build stats

Test stats 🧪

Trends 🧪

vigneshshanmugam Mar 9, 2021

hmdhk left a comment

vigneshshanmugam commented Mar 10, 2021 •

edited

Loading

vigneshshanmugam commented Mar 11, 2021

hmdhk commented Mar 15, 2021

vigneshshanmugam commented Mar 15, 2021

chore: migrate angular e2e app to ng cli #974

chore: migrate angular e2e app to ng cli #974

Conversation

vigneshshanmugam commented Mar 6, 2021 • edited Loading

apmmachine commented Mar 6, 2021 • edited Loading

📦 Bundlesize report

apmmachine commented Mar 6, 2021 • edited Loading

💚 Build Succeeded

Build stats

Test stats 🧪

Trends 🧪

vigneshshanmugam Mar 9, 2021

Choose a reason for hiding this comment

hmdhk left a comment

Choose a reason for hiding this comment

vigneshshanmugam commented Mar 10, 2021 • edited Loading

vigneshshanmugam commented Mar 11, 2021

hmdhk commented Mar 15, 2021

vigneshshanmugam commented Mar 15, 2021

vigneshshanmugam commented Mar 6, 2021 •

edited

Loading

apmmachine commented Mar 6, 2021 •

edited

Loading

apmmachine commented Mar 6, 2021 •

edited

Loading

vigneshshanmugam commented Mar 10, 2021 •

edited

Loading