chore(rum-angular): fix build warning and formatting #978

vigneshshanmugam · 2021-03-10T21:07:15Z

part of Add support for Angular 9, 10 and 11 #962
Fixes the warnings in the @elastic/apm-rum-angular library build - Requires typescript >= 3.8 for importing the type information alone.
Updates to prettier 2 which is required for migrating to typescript 3.8 - https://prettier.io/blog/2020/03/21/2.0.0.html#typescript
Formatting changes for all function expression as there is no options to control it through prettier - https://prettier.io/blog/2020/03/21/2.0.0.html#javascript-1

To be merged after #974

* feat(rum-angular): add support for angular 9 * chore: set up the ng build toolchain * feat: rewrite the apm module under src/* * chore: set up the testing with ng * chore: make karma:dev work * chore: make karma:coverage work * chore: address review and disable saucelabs * chore: fix local link and coverage test

apmmachine · 2021-03-10T22:20:53Z

📦 Bundlesize report

Filename	Size(bundled)	Size(gzip)	Diff(gzip)
elastic-apm-opentracing.umd.min.js	62.2 KiB	19.8 KiB
elastic-apm-rum.umd.min.js	56.3 KiB	18.4 KiB

apmmachine · 2021-03-10T22:20:55Z

💔 Build Failed

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Build Cause: Pull request #978 opened
Start Time: 2021-03-10T21:07:30.052+0000
Duration: 73 min 15 sec
Commit: 4be1c2f

Test stats 🧪

Test	Results
Failed	0
Passed	1037
Skipped	13
Total	1050

Trends 🧪

Steps errors

Expand to view the steps failures

`Run tests: Elastic Stack 8.0.0-SNAPSHOT - @elastic/apm-rum-angular - none`

Took 5 min 33 sec . View more details on here
Description: .ci/scripts/test.sh

`Shell Script`

Took 7 min 40 sec . View more details on here
Description: ./.ci/scripts/benchmarks.sh

Log output

Expand to view the last 100 lines of log output

[2021-03-10T22:20:14.333Z] node-playwright        | @elastic/apm-rum-core:     "suite": "PerformanceMonitoring",
[2021-03-10T22:20:14.333Z] node-playwright        | @elastic/apm-rum-core:     "name": "sendEvents",
[2021-03-10T22:20:14.333Z] node-playwright        | @elastic/apm-rum-core:     "mean": 0.0007724825942938604,
[2021-03-10T22:20:14.333Z] node-playwright        | @elastic/apm-rum-core:     "count": 155,
[2021-03-10T22:20:14.333Z] node-playwright        | @elastic/apm-rum-core:     "browser": "headlesschrome",
[2021-03-10T22:20:14.333Z] node-playwright        | @elastic/apm-rum-core:     "hz": 1294.5275497296054,
[2021-03-10T22:20:14.333Z] node-playwright        | @elastic/apm-rum-core:     "unit": "ops/sec"
[2021-03-10T22:20:14.333Z] node-playwright        | @elastic/apm-rum-core:   }
[2021-03-10T22:20:14.333Z] node-playwright        | @elastic/apm-rum-core: ]
[2021-03-10T22:20:14.333Z] node-playwright        | @elastic/apm-rum: > @elastic/apm-rum@5.6.3 bench /app/packages/rum
[2021-03-10T22:20:14.333Z] node-playwright        | @elastic/apm-rum: > npm run build:umd && node test/benchmarks/run.js
[2021-03-10T22:20:14.334Z] node-playwright        | @elastic/apm-rum: > @elastic/apm-rum@5.6.3 build:umd /app/packages/rum
[2021-03-10T22:20:14.334Z] node-playwright        | @elastic/apm-rum: > webpack --colors
[2021-03-10T22:20:20.800Z] node-playwright        | @elastic/apm-rum: Webpack Bundle Analyzer saved report to /app/packages/rum/reports/apm-rum-report.html
[2021-03-10T22:20:21.498Z] node-playwright        | @elastic/apm-rum: Webpack Bundle Analyzer saved report to /app/packages/rum/reports/apm-opentracing-report.html
[2021-03-10T22:20:22.201Z] node-playwright        | @elastic/apm-rum: Webpack Bundle Analyzer saved stats file to /app/packages/rum/reports/apm-rum-stats.json
[2021-03-10T22:20:22.201Z] node-playwright        | @elastic/apm-rum: Webpack Bundle Analyzer saved stats file to /app/packages/rum/reports/apm-opentracing-stats.json
[2021-03-10T22:20:22.201Z] node-playwright        | @elastic/apm-rum: Hash: e611eeeed20782d79fd07d87443544a4c891d319169f415a380400d82ca2244267ab2027439f6044
[2021-03-10T22:20:22.201Z] node-playwright        | @elastic/apm-rum: Version: webpack 4.44.1
[2021-03-10T22:20:22.201Z] node-playwright        | @elastic/apm-rum: Child
[2021-03-10T22:20:22.201Z] node-playwright        | @elastic/apm-rum:     Hash: e611eeeed20782d79fd0
[2021-03-10T22:20:22.201Z] node-playwright        | @elastic/apm-rum:     Time: 4477ms
[2021-03-10T22:20:22.201Z] node-playwright        | @elastic/apm-rum:     Built at: 03/10/2021 10:20:19 PM
[2021-03-10T22:20:22.202Z] node-playwright        | @elastic/apm-rum:                      Asset     Size           Chunks                    Chunk Names
[2021-03-10T22:20:22.202Z] node-playwright        | @elastic/apm-rum:     elastic-apm-rum.umd.js  539 KiB  elastic-apm-rum  [emitted]  [big]  elastic-apm-rum
[2021-03-10T22:20:22.202Z] node-playwright        | @elastic/apm-rum:     Entrypoint elastic-apm-rum [big] = elastic-apm-rum.umd.js
[2021-03-10T22:20:22.202Z] node-playwright        | @elastic/apm-rum: Child
[2021-03-10T22:20:22.202Z] node-playwright        | @elastic/apm-rum:     Hash: 7d87443544a4c891d319
[2021-03-10T22:20:22.203Z] node-playwright        | @elastic/apm-rum:     Time: 5658ms
[2021-03-10T22:20:22.203Z] node-playwright        | @elastic/apm-rum:     Built at: 03/10/2021 10:20:20 PM
[2021-03-10T22:20:22.203Z] node-playwright        | @elastic/apm-rum:                              Asset      Size  Chunks                   Chunk Names
[2021-03-10T22:20:22.203Z] node-playwright        | @elastic/apm-rum:         elastic-apm-rum.umd.min.js  56.3 KiB       0  [emitted]        elastic-apm-rum
[2021-03-10T22:20:22.203Z] node-playwright        | @elastic/apm-rum:     elastic-apm-rum.umd.min.js.map   240 KiB       0  [emitted] [dev]  elastic-apm-rum
[2021-03-10T22:20:22.203Z] node-playwright        | @elastic/apm-rum:     Entrypoint elastic-apm-rum = elastic-apm-rum.umd.min.js elastic-apm-rum.umd.min.js.map
[2021-03-10T22:20:22.204Z] node-playwright        | @elastic/apm-rum: Child
[2021-03-10T22:20:22.204Z] node-playwright        | @elastic/apm-rum:     Hash: 169f415a380400d82ca2
[2021-03-10T22:20:22.204Z] node-playwright        | @elastic/apm-rum:     Time: 4462ms
[2021-03-10T22:20:22.204Z] node-playwright        | @elastic/apm-rum:     Built at: 03/10/2021 10:20:19 PM
[2021-03-10T22:20:22.204Z] node-playwright        | @elastic/apm-rum:                              Asset     Size                   Chunks                    Chunk Names
[2021-03-10T22:20:22.204Z] node-playwright        | @elastic/apm-rum:     elastic-apm-opentracing.umd.js  544 KiB  elastic-apm-opentracing  [emitted]  [big]  elastic-apm-opentracing
[2021-03-10T22:20:22.205Z] node-playwright        | @elastic/apm-rum:     Entrypoint elastic-apm-opentracing [big] = elastic-apm-opentracing.umd.js
[2021-03-10T22:20:22.205Z] node-playwright        | @elastic/apm-rum: Child
[2021-03-10T22:20:22.205Z] node-playwright        | @elastic/apm-rum:     Hash: 244267ab2027439f6044
[2021-03-10T22:20:22.205Z] node-playwright        | @elastic/apm-rum:     Time: 6128ms
[2021-03-10T22:20:22.205Z] node-playwright        | @elastic/apm-rum:     Built at: 03/10/2021 10:20:21 PM
[2021-03-10T22:20:22.205Z] node-playwright        | @elastic/apm-rum:                                      Asset      Size  Chunks                          Chunk Names
[2021-03-10T22:20:22.205Z] node-playwright        | @elastic/apm-rum:         elastic-apm-opentracing.umd.min.js  62.2 KiB       0  [emitted]        [big]  elastic-apm-opentracing
[2021-03-10T22:20:22.206Z] node-playwright        | @elastic/apm-rum:     elastic-apm-opentracing.umd.min.js.map   277 KiB       0  [emitted] [dev]         elastic-apm-opentracing
[2021-03-10T22:20:22.206Z] node-playwright        | @elastic/apm-rum:     Entrypoint elastic-apm-opentracing = elastic-apm-opentracing.umd.min.js elastic-apm-opentracing.umd.min.js.map
[2021-03-10T22:20:22.206Z] node-playwright        | @elastic/apm-rum:     
[2021-03-10T22:20:22.207Z] node-playwright        | @elastic/apm-rum:     WARNING in asset size limit: The following asset(s) exceed the recommended size limit (60 KiB).
[2021-03-10T22:20:22.207Z] node-playwright        | @elastic/apm-rum:     This can impact web performance.
[2021-03-10T22:20:22.207Z] node-playwright        | @elastic/apm-rum:     Assets: 
[2021-03-10T22:20:22.207Z] node-playwright        | @elastic/apm-rum:       elastic-apm-opentracing.umd.min.js (62.2 KiB)
[2021-03-10T22:20:22.207Z] node-playwright        | @elastic/apm-rum:     
[2021-03-10T22:20:22.207Z] node-playwright        | @elastic/apm-rum:     WARNING in webpack performance recommendations: 
[2021-03-10T22:20:22.207Z] node-playwright        | @elastic/apm-rum:     You can limit the size of your bundles by using import() or require.ensure to lazy load some parts of your application.
[2021-03-10T22:20:22.207Z] node-playwright        | @elastic/apm-rum:     For more info visit https://webpack.js.org/guides/code-splitting/
[2021-03-10T22:20:26.327Z] node-playwright        | @elastic/apm-rum: custom apm build -  apm-rum-with-name.umd.min.js generated
[2021-03-10T22:20:26.327Z] node-playwright        | @elastic/apm-rum: Server listening at http://localhost:9000
[2021-03-10T22:20:37.737Z] node-playwright        | @elastic/apm-rum: Error running RUM benchmark script browserType.launch: Host system is missing dependencies!
[2021-03-10T22:20:37.737Z] node-playwright        | @elastic/apm-rum:   Install missing packages with:
[2021-03-10T22:20:37.737Z] node-playwright        | @elastic/apm-rum:       sudo apt-get install gstreamer1.0-libav
[2021-03-10T22:20:37.738Z] node-playwright        | @elastic/apm-rum: Error
[2021-03-10T22:20:37.738Z] node-playwright        | @elastic/apm-rum:     at Object.captureStackTrace (/app/node_modules/playwright/lib/utils/stackTrace.js:48:19)
[2021-03-10T22:20:37.738Z] node-playwright        | @elastic/apm-rum:     at Connection.sendMessageToServer (/app/node_modules/playwright/lib/client/connection.js:69:48)
[2021-03-10T22:20:37.738Z] node-playwright        | @elastic/apm-rum:     at Proxy.<anonymous> (/app/node_modules/playwright/lib/client/channelOwner.js:64:61)
[2021-03-10T22:20:37.738Z] node-playwright        | @elastic/apm-rum:     at /app/node_modules/playwright/lib/client/browserType.js:64:67
[2021-03-10T22:20:37.738Z] node-playwright        | @elastic/apm-rum:     at BrowserType._wrapApiCall (/app/node_modules/playwright/lib/client/channelOwner.js:77:34)
[2021-03-10T22:20:37.738Z] node-playwright        | @elastic/apm-rum:     at BrowserType.launch (/app/node_modules/playwright/lib/client/browserType.js:55:21)
[2021-03-10T22:20:37.738Z] node-playwright        | @elastic/apm-rum:     at launchBrowser (/app/packages/rum/test/benchmarks/profiler.js:36:33)
[2021-03-10T22:20:37.738Z] node-playwright        | @elastic/apm-rum:     at run (/app/packages/rum/test/benchmarks/run.js:75:33)
[2021-03-10T22:20:37.738Z] node-playwright        | @elastic/apm-rum: npm ERR! code ELIFECYCLE
[2021-03-10T22:20:37.738Z] node-playwright        | @elastic/apm-rum: npm ERR! errno 1
[2021-03-10T22:20:37.738Z] node-playwright        | @elastic/apm-rum: npm ERR! @elastic/apm-rum@5.6.3 bench: `npm run build:umd && node test/benchmarks/run.js`
[2021-03-10T22:20:37.738Z] node-playwright        | @elastic/apm-rum: npm ERR! Exit status 1
[2021-03-10T22:20:37.738Z] node-playwright        | @elastic/apm-rum: npm ERR! 
[2021-03-10T22:20:37.739Z] node-playwright        | @elastic/apm-rum: npm ERR! Failed at the @elastic/apm-rum@5.6.3 bench script.
[2021-03-10T22:20:37.739Z] node-playwright        | @elastic/apm-rum: npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
[2021-03-10T22:20:37.739Z] node-playwright        | @elastic/apm-rum: npm ERR! A complete log of this run can be found in:
[2021-03-10T22:20:37.739Z] node-playwright        | @elastic/apm-rum: npm ERR!     /app/.npm/_logs/2021-03-10T22_20_36_217Z-debug.log
[2021-03-10T22:20:37.739Z] node-playwright        | lerna ERR! npm run bench exited 1 in '@elastic/apm-rum'
[2021-03-10T22:20:37.739Z] node-playwright exited with code 1
[2021-03-10T22:20:37.739Z] Aborting on container exit...
[2021-03-10T22:20:39.229Z] Post stage
[2021-03-10T22:20:39.373Z] Archiving artifacts
[2021-03-10T22:20:39.566Z] [INFO] sendBenchmarks is not enabled for PRs
[2021-03-10T22:20:42.981Z] Stage "Coverage" skipped due to earlier failure(s)
[2021-03-10T22:20:43.117Z] Stage "Release" skipped due to earlier failure(s)
[2021-03-10T22:20:43.178Z] Stage "Release" skipped due to earlier failure(s)
[2021-03-10T22:20:43.302Z] Stage "Release" skipped due to earlier failure(s)
[2021-03-10T22:20:43.456Z] Stage "Release" skipped due to earlier failure(s)
[2021-03-10T22:20:43.663Z] Stage "Opbeans" skipped due to earlier failure(s)
[2021-03-10T22:20:44.170Z] Running on Jenkins in /var/lib/jenkins/workspace/ent-rum_apm-agent-rum-mbp_PR-978
[2021-03-10T22:20:44.328Z] [INFO] getVaultSecret: Getting secrets
[2021-03-10T22:20:44.604Z] Masking supported pattern matches of $VAULT_ADDR or $VAULT_ROLE_ID or $VAULT_SECRET_ID
[2021-03-10T22:20:45.747Z] + chmod 755 generate-build-data.sh
[2021-03-10T22:20:45.748Z] + ./generate-build-data.sh https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-rum/apm-agent-rum-mbp/PR-978/ https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-rum/apm-agent-rum-mbp/PR-978/runs/1 FAILURE 4395416
[2021-03-10T22:20:45.998Z] INFO: curl https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-rum/apm-agent-rum-mbp/PR-978/runs/1/steps/?limit=10000 -o steps-info.json
[2021-03-10T22:20:46.909Z] INFO: curl https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-rum/apm-agent-rum-mbp/PR-978/runs/1/tests/?status=FAILED -o tests-errors.json

vigneshshanmugam · 2021-03-11T20:02:04Z

Closing this PR as it would better to have the formatting changes in master ( updating prettier and eslint in master) and then do a PR for fixing the build warnings. Split the work here - #981

vigneshshanmugam added 13 commits March 8, 2021 09:32

chore: migrate angular e2e app to ng cli

e165151

chore: make build system work for e2e

2117699

chore: make saucelabs work

ce6f8d0

chore: enable saucelabs test for angular

5429db6

chore: fix test scripts

28f2d59

chore: target es5 and add browserlist

efe083f

chore: only run saucelabs test in jenkins

cbbef01

chore: update prod apmserver url

8fcb84d

chore: transpile apmservermock correctly

c692b29

chore: revert jenkinsfile

f1a2fcc

chore: fix warnings in build

66a8359

chore: fix build warning and formatting

4be1c2f

vigneshshanmugam changed the title ~~Warnings angular~~ chore(rum-angular): fix build warning and formatting Mar 10, 2021

vigneshshanmugam mentioned this pull request Mar 11, 2021

chore: migrate angular e2e app to ng cli #974

Merged

vigneshshanmugam force-pushed the feat-angular branch from afbc68d to b7c532e Compare March 11, 2021 19:35

vigneshshanmugam closed this Mar 11, 2021

vigneshshanmugam deleted the warnings-angular branch March 11, 2021 20:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(rum-angular): fix build warning and formatting #978

chore(rum-angular): fix build warning and formatting #978

vigneshshanmugam commented Mar 10, 2021 •

edited by zube bot

Loading

apmmachine commented Mar 10, 2021

apmmachine commented Mar 10, 2021

Build stats

Test stats 🧪

Trends 🧪

`Run tests: Elastic Stack 8.0.0-SNAPSHOT - @elastic/apm-rum-angular - none`

`Shell Script`

vigneshshanmugam commented Mar 11, 2021

chore(rum-angular): fix build warning and formatting #978

chore(rum-angular): fix build warning and formatting #978

Conversation

vigneshshanmugam commented Mar 10, 2021 • edited by zube bot Loading

apmmachine commented Mar 10, 2021

📦 Bundlesize report

apmmachine commented Mar 10, 2021

💔 Build Failed

Build stats

Test stats 🧪

Trends 🧪

Steps errors

Run tests: Elastic Stack 8.0.0-SNAPSHOT - @elastic/apm-rum-angular - none

Shell Script

Log output

vigneshshanmugam commented Mar 11, 2021

vigneshshanmugam commented Mar 10, 2021 •

edited by zube bot

Loading

`Run tests: Elastic Stack 8.0.0-SNAPSHOT - @elastic/apm-rum-angular - none`

`Shell Script`