BREAKING CHANGE(rum-angular): add support for angular 9 #971

vigneshshanmugam · 2021-02-25T23:33:50Z

fix Anguar Package Format #757, Could not find a declaration file for module '@elastic/apm-rum-angular' #884, Cyclic Dependency with Angular Router #463, RUM-Agent slows down startup since Angular 9 #693
part of Add support for Angular 9, 10 and 11 #962
Extracted some of the work done by @chriscarpenter12 on PR wip adding angular project using ng cli #746.. Huge thanks for the help in starting it.
Supports Angular Packing format and AOT compilation via metadata.json as we get those for free using the ng toolschain.
We now expose 1 module, 1 service and 1 Error handler from the @elastic/apm-rum-angular package.
- ApmModule
- ApmService
- ApmErrorHandler
We use ng ecosystem which is the recommended way to build, test and publish the angular libraries and application.
- ng-packgr is used for building the library - check ng-package.json
- Each task build, test is specified using angular.json which has specific tsconfig respectively.

Note to Reviewer: Review commit by commit for better understanding

Tasks to be done in separate PR

E2E migration / tests will be done in separate PR to reduce the number of changes in a single PR - chore: migrate angular e2e app to ng cli #974
Moving to angular 10, 11 etc.
Updating documentation and breaking changes strategy

These tasks are already added to the main issue #962 to keep changes minimal and moving faster with iteration.

apmmachine · 2021-02-25T23:44:00Z

📦 Bundlesize report

Filename	Size(bundled)	Size(gzip)	Diff(gzip)
elastic-apm-opentracing.umd.min.js	62.2 KiB	19.8 KiB	💚 0 Bytes
elastic-apm-rum.umd.min.js	56.3 KiB	18.4 KiB	💚 0 Bytes

apmmachine · 2021-02-25T23:44:02Z

💔 Build Failed

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Build Cause: Pull request #971 event
Start Time: 2021-03-08T10:40:52.991+0000
Duration: 5 min 1 sec
Commit: 0058b02

Trends 🧪

Steps errors

Expand to view the steps failures

`Lint`

Took 2 min 58 sec . View more details on here
Description: HOME=$(pwd) .ci/scripts/lint.sh

Log output

Expand to view the last 100 lines of log output

[2021-03-08T10:45:47.757Z] npm ERR! code ELIFECYCLE
[2021-03-08T10:45:47.757Z] npm ERR! errno 1
[2021-03-08T10:45:47.757Z] npm ERR! elastic-apm-rum@0.0.0-monorepo lint: `run-p --silent lint:*`
[2021-03-08T10:45:47.757Z] npm ERR! Exit status 1
[2021-03-08T10:45:47.757Z] npm ERR! 
[2021-03-08T10:45:47.757Z] npm ERR! Failed at the elastic-apm-rum@0.0.0-monorepo lint script.
[2021-03-08T10:45:47.757Z] npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
[2021-03-08T10:45:47.757Z] 
[2021-03-08T10:45:47.757Z] npm ERR! A complete log of this run can be found in:
[2021-03-08T10:45:47.757Z] npm ERR!     /var/lib/jenkins/workspace/ent-rum_apm-agent-rum-mbp_PR-971/src/github.com/elastic/apm-agent-rum-js/.npm/_logs/2021-03-08T10_45_47_524Z-debug.log
[2021-03-08T10:45:47.757Z] + [[ -n https://apm-ci.elastic.co/ ]]
[2021-03-08T10:45:47.757Z] ++ npm bin
[2021-03-08T10:45:48.018Z] + export PATH=/var/lib/jenkins/workspace/ent-rum_apm-agent-rum-mbp_PR-971/src/github.com/elastic/apm-agent-rum-js/node_modules/.bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
[2021-03-08T10:45:48.018Z] + PATH=/var/lib/jenkins/workspace/ent-rum_apm-agent-rum-mbp_PR-971/src/github.com/elastic/apm-agent-rum-js/node_modules/.bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
[2021-03-08T10:45:48.018Z] ++ pwd
[2021-03-08T10:45:48.018Z] + export HOME=/var/lib/jenkins/workspace/ent-rum_apm-agent-rum-mbp_PR-971/src/github.com/elastic/apm-agent-rum-js
[2021-03-08T10:45:48.018Z] + HOME=/var/lib/jenkins/workspace/ent-rum_apm-agent-rum-mbp_PR-971/src/github.com/elastic/apm-agent-rum-js
[2021-03-08T10:45:48.018Z] + [[ -z 971 ]]
[2021-03-08T10:45:48.018Z] + commitlint --from=origin/feat-angular --to=0058b0296260263aa55eea3b43e5711ddc3b6af2
[2021-03-08T10:45:48.277Z] + [[ -n BREAKING CHANGE(rum-angular): add support for angular 9 ]]
[2021-03-08T10:45:48.277Z] ++ echo -n 'BREAKING CHANGE(rum-angular): add support for angular 9'
[2021-03-08T10:45:48.277Z] ++ wc -c
[2021-03-08T10:45:48.277Z] + titleLength=55
[2021-03-08T10:45:48.277Z] + titleResult=0
[2021-03-08T10:45:48.277Z] + '[' 55 -ge 65 ']'
[2021-03-08T10:45:48.277Z] + echo 'BREAKING CHANGE(rum-angular): add support for angular 9'
[2021-03-08T10:45:48.277Z] + commitlint
[2021-03-08T10:45:48.848Z] ⧗   input: BREAKING CHANGE(rum-angular): add support for angular 9
[2021-03-08T10:45:48.848Z] ✖   subject may not be empty [subject-empty]
[2021-03-08T10:45:48.848Z] ✖   type may not be empty [type-empty]
[2021-03-08T10:45:48.848Z] 
[2021-03-08T10:45:48.848Z] ✖   found 2 problems, 0 warnings
[2021-03-08T10:45:48.848Z] ⓘ   Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint
[2021-03-08T10:45:48.848Z] 
[2021-03-08T10:45:48.887Z] $ docker stop --time=1 d01f4d01a741f6476d2e41e65e9419fe412c09d399b6c376f8e3846bed943f15
[2021-03-08T10:45:50.294Z] $ docker rm -f d01f4d01a741f6476d2e41e65e9419fe412c09d399b6c376f8e3846bed943f15
[2021-03-08T10:45:51.323Z] Stage "Test Pupperteer" skipped due to earlier failure(s)
[2021-03-08T10:45:51.461Z] Stage "Matrix - STACK_VERSION = '8.0.0-SNAPSHOT', SCOPE = '@elastic/apm-rum'" skipped due to earlier failure(s)
[2021-03-08T10:45:51.462Z] Stage "Matrix - STACK_VERSION = '7.7.0', SCOPE = '@elastic/apm-rum'" skipped due to earlier failure(s)
[2021-03-08T10:45:51.462Z] Stage "Matrix - STACK_VERSION = '7.0.0', SCOPE = '@elastic/apm-rum'" skipped due to earlier failure(s)
[2021-03-08T10:45:51.463Z] Stage "Matrix - STACK_VERSION = '8.0.0-SNAPSHOT', SCOPE = '@elastic/apm-rum-core'" skipped due to earlier failure(s)
[2021-03-08T10:45:51.464Z] Stage "Matrix - STACK_VERSION = '7.7.0', SCOPE = '@elastic/apm-rum-core'" skipped due to earlier failure(s)
[2021-03-08T10:45:51.464Z] Stage "Matrix - STACK_VERSION = '7.0.0', SCOPE = '@elastic/apm-rum-core'" skipped due to earlier failure(s)
[2021-03-08T10:45:51.465Z] Stage "Matrix - STACK_VERSION = '8.0.0-SNAPSHOT', SCOPE = '@elastic/apm-rum-react'" skipped due to earlier failure(s)
[2021-03-08T10:45:51.465Z] Stage "Matrix - STACK_VERSION = '7.7.0', SCOPE = '@elastic/apm-rum-react'" skipped due to earlier failure(s)
[2021-03-08T10:45:51.466Z] Stage "Matrix - STACK_VERSION = '7.0.0', SCOPE = '@elastic/apm-rum-react'" skipped due to earlier failure(s)
[2021-03-08T10:45:51.466Z] Stage "Matrix - STACK_VERSION = '8.0.0-SNAPSHOT', SCOPE = '@elastic/apm-rum-angular'" skipped due to earlier failure(s)
[2021-03-08T10:45:51.467Z] Stage "Matrix - STACK_VERSION = '7.7.0', SCOPE = '@elastic/apm-rum-angular'" skipped due to earlier failure(s)
[2021-03-08T10:45:51.467Z] Stage "Matrix - STACK_VERSION = '7.0.0', SCOPE = '@elastic/apm-rum-angular'" skipped due to earlier failure(s)
[2021-03-08T10:45:51.468Z] Stage "Matrix - STACK_VERSION = '8.0.0-SNAPSHOT', SCOPE = '@elastic/apm-rum-vue'" skipped due to earlier failure(s)
[2021-03-08T10:45:51.469Z] Stage "Matrix - STACK_VERSION = '7.7.0', SCOPE = '@elastic/apm-rum-vue'" skipped due to earlier failure(s)
[2021-03-08T10:45:51.469Z] Stage "Matrix - STACK_VERSION = '7.0.0', SCOPE = '@elastic/apm-rum-vue'" skipped due to earlier failure(s)
[2021-03-08T10:45:51.594Z] Stage "Matrix - STACK_VERSION = '8.0.0-SNAPSHOT', SCOPE = '@elastic/apm-rum'" skipped due to earlier failure(s)
[2021-03-08T10:45:51.596Z] Stage "Matrix - STACK_VERSION = '7.7.0', SCOPE = '@elastic/apm-rum'" skipped due to earlier failure(s)
[2021-03-08T10:45:51.597Z] Stage "Matrix - STACK_VERSION = '7.0.0', SCOPE = '@elastic/apm-rum'" skipped due to earlier failure(s)
[2021-03-08T10:45:51.597Z] Stage "Matrix - STACK_VERSION = '8.0.0-SNAPSHOT', SCOPE = '@elastic/apm-rum-core'" skipped due to earlier failure(s)
[2021-03-08T10:45:51.598Z] Stage "Matrix - STACK_VERSION = '7.7.0', SCOPE = '@elastic/apm-rum-core'" skipped due to earlier failure(s)
[2021-03-08T10:45:51.599Z] Stage "Matrix - STACK_VERSION = '7.0.0', SCOPE = '@elastic/apm-rum-core'" skipped due to earlier failure(s)
[2021-03-08T10:45:51.600Z] Stage "Matrix - STACK_VERSION = '8.0.0-SNAPSHOT', SCOPE = '@elastic/apm-rum-react'" skipped due to earlier failure(s)
[2021-03-08T10:45:51.601Z] Stage "Matrix - STACK_VERSION = '7.7.0', SCOPE = '@elastic/apm-rum-react'" skipped due to earlier failure(s)
[2021-03-08T10:45:51.601Z] Stage "Matrix - STACK_VERSION = '7.0.0', SCOPE = '@elastic/apm-rum-react'" skipped due to earlier failure(s)
[2021-03-08T10:45:51.602Z] Stage "Matrix - STACK_VERSION = '8.0.0-SNAPSHOT', SCOPE = '@elastic/apm-rum-angular'" skipped due to earlier failure(s)
[2021-03-08T10:45:51.603Z] Stage "Matrix - STACK_VERSION = '7.7.0', SCOPE = '@elastic/apm-rum-angular'" skipped due to earlier failure(s)
[2021-03-08T10:45:51.603Z] Stage "Matrix - STACK_VERSION = '7.0.0', SCOPE = '@elastic/apm-rum-angular'" skipped due to earlier failure(s)
[2021-03-08T10:45:51.604Z] Stage "Matrix - STACK_VERSION = '8.0.0-SNAPSHOT', SCOPE = '@elastic/apm-rum-vue'" skipped due to earlier failure(s)
[2021-03-08T10:45:51.605Z] Stage "Matrix - STACK_VERSION = '7.7.0', SCOPE = '@elastic/apm-rum-vue'" skipped due to earlier failure(s)
[2021-03-08T10:45:51.606Z] Stage "Matrix - STACK_VERSION = '7.0.0', SCOPE = '@elastic/apm-rum-vue'" skipped due to earlier failure(s)
[2021-03-08T10:45:51.994Z] Failed in branch Matrix - STACK_VERSION = '8.0.0-SNAPSHOT', SCOPE = '@elastic/apm-rum'
[2021-03-08T10:45:51.996Z] Failed in branch Matrix - STACK_VERSION = '7.7.0', SCOPE = '@elastic/apm-rum'
[2021-03-08T10:45:51.997Z] Failed in branch Matrix - STACK_VERSION = '7.0.0', SCOPE = '@elastic/apm-rum'
[2021-03-08T10:45:51.997Z] Failed in branch Matrix - STACK_VERSION = '8.0.0-SNAPSHOT', SCOPE = '@elastic/apm-rum-core'
[2021-03-08T10:45:51.998Z] Failed in branch Matrix - STACK_VERSION = '7.7.0', SCOPE = '@elastic/apm-rum-core'
[2021-03-08T10:45:51.999Z] Failed in branch Matrix - STACK_VERSION = '7.0.0', SCOPE = '@elastic/apm-rum-core'
[2021-03-08T10:45:52.000Z] Failed in branch Matrix - STACK_VERSION = '8.0.0-SNAPSHOT', SCOPE = '@elastic/apm-rum-react'
[2021-03-08T10:45:52.000Z] Failed in branch Matrix - STACK_VERSION = '7.7.0', SCOPE = '@elastic/apm-rum-react'
[2021-03-08T10:45:52.001Z] Failed in branch Matrix - STACK_VERSION = '7.0.0', SCOPE = '@elastic/apm-rum-react'
[2021-03-08T10:45:52.001Z] Failed in branch Matrix - STACK_VERSION = '8.0.0-SNAPSHOT', SCOPE = '@elastic/apm-rum-angular'
[2021-03-08T10:45:52.002Z] Failed in branch Matrix - STACK_VERSION = '7.7.0', SCOPE = '@elastic/apm-rum-angular'
[2021-03-08T10:45:52.003Z] Failed in branch Matrix - STACK_VERSION = '7.0.0', SCOPE = '@elastic/apm-rum-angular'
[2021-03-08T10:45:52.004Z] Failed in branch Matrix - STACK_VERSION = '8.0.0-SNAPSHOT', SCOPE = '@elastic/apm-rum-vue'
[2021-03-08T10:45:52.004Z] Failed in branch Matrix - STACK_VERSION = '7.7.0', SCOPE = '@elastic/apm-rum-vue'
[2021-03-08T10:45:52.005Z] Failed in branch Matrix - STACK_VERSION = '7.0.0', SCOPE = '@elastic/apm-rum-vue'
[2021-03-08T10:45:52.076Z] Stage "Stack 8.0.0-SNAPSHOT SauceLabs" skipped due to earlier failure(s)
[2021-03-08T10:45:52.116Z] Stage "Integration Tests" skipped due to earlier failure(s)
[2021-03-08T10:45:52.156Z] Stage "Benchmarks" skipped due to earlier failure(s)
[2021-03-08T10:45:52.209Z] Stage "Coverage" skipped due to earlier failure(s)
[2021-03-08T10:45:52.257Z] Stage "Release" skipped due to earlier failure(s)
[2021-03-08T10:45:52.279Z] Stage "Release" skipped due to earlier failure(s)
[2021-03-08T10:45:52.326Z] Stage "Release" skipped due to earlier failure(s)
[2021-03-08T10:45:52.372Z] Stage "Release" skipped due to earlier failure(s)
[2021-03-08T10:45:52.438Z] Stage "Opbeans" skipped due to earlier failure(s)
[2021-03-08T10:45:52.774Z] Running on worker-1225339 in /var/lib/jenkins/workspace/ent-rum_apm-agent-rum-mbp_PR-971
[2021-03-08T10:45:52.877Z] [INFO] getVaultSecret: Getting secrets
[2021-03-08T10:45:53.176Z] Masking supported pattern matches of $VAULT_ADDR or $VAULT_ROLE_ID or $VAULT_SECRET_ID
[2021-03-08T10:45:55.209Z] + chmod 755 generate-build-data.sh
[2021-03-08T10:45:55.210Z] + ./generate-build-data.sh https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-rum/apm-agent-rum-mbp/PR-971/ https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-rum/apm-agent-rum-mbp/PR-971/runs/6 FAILURE 300826
[2021-03-08T10:45:55.210Z] INFO: curl https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-rum/apm-agent-rum-mbp/PR-971/runs/6/steps/?limit=10000 -o steps-info.json
[2021-03-08T10:45:55.912Z] INFO: curl https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-rum/apm-agent-rum-mbp/PR-971/runs/6/tests/?status=FAILED -o tests-errors.json
[2021-03-08T10:45:55.912Z] Retry 1/3 exited 22, retrying in 1 seconds...
[2021-03-08T10:45:57.366Z] Retry 2/3 exited 22, retrying in 2 seconds...

vigneshshanmugam · 2021-02-26T01:18:26Z

@chriscarpenter12 If you have some time, can you have a look at the PR.

chriscarpenter12 · 2021-02-26T01:41:14Z

Is the plan to get support out for Angular 9 now? Current version is 11 with 12 coming out soon.

chriscarpenter12

Otherwise looks good. Thanks @vigneshshanmugam !

packages/rum-angular/src/apm.module.ts

packages/rum-angular/src/apm.service.ts

chriscarpenter12 · 2021-02-26T01:57:08Z

What will be the process for upgrading apps? Because devs will need to remove the ApmService in their AppModule providers?

vigneshshanmugam · 2021-02-26T04:47:57Z

Is the plan to get support out for Angular 9 now? Current version is 11 with 12 coming out soon.

No, I am just doing it for 9 now to keep the changes minimal. We will most likely skip version 9 and go straight to 11 as its the current active version https://angular.io/guide/releases#support-policy-and-schedule. Will do a follow up PR

What will be the process for upgrading apps? Because devs will need to remove the ApmService in their AppModule providers?

Still figuring that out, this is not the complete PR though. its just updating the library part. I am going to do follow up PR's on how we can do it for our e2e app and also figure out the update path.

hmdhk

Thanks @vigneshshanmugam , A few points:

It seems that this PR breaks the support for version 8, which is fine but we should release this in a breaking change (major) version.
I think the saucelabs test would give us a better assessment of what might break, so I would prefer if we enable that before merging. We can migrate e2e tests in a separate PR.

packages/rum-angular/package.json

hmdhk · 2021-03-04T09:09:40Z

packages/rum-angular/src/apm.service.ts


  init(config) {
-    const apmInstance = ApmService.apm.init(config)
+    const apmInstance = this.ngZone.runOutsideAngular(() =>
+      this.apm.init(config)


Why does the init has to be out side the zone?

Check the discussion here - #971 (comment)

packages/rum-angular/test/polyfills.ts

package.json

vigneshshanmugam · 2021-03-04T15:48:53Z

@jahtalab

It seems that this PR breaks the support for version 8, which is fine but we should release this in a breaking change (major) version.

Yes thats right. We will release a new major for the angular package alone.

I think the saucelabs test would give us a better assessment of what might break, so I would prefer if we enable that before merging. We can migrate e2e tests in a separate PR.

We have to change the whole build pipeline for that to even go to that step. We have to convert the test/e2e/app in to an angular application. Let's do it in a separate PR, it will make things easier for review.

vigneshshanmugam · 2021-03-05T18:33:03Z

@jahtalab If there is no major concern on the this PR, I am going to go ahead and merge and address some of the concerns on the next E2E test PR which would make things easier to understand and answer some of your questions as well. Makes my iteration faster.

hmdhk · 2021-03-08T08:34:49Z

@vigneshshanmugam , I would like to run this locally but without the tests it's a bit hard to verify the code actually does what it's supposed to do.

Would it help you if we make an intermediary branch to merge this into? This has the added benefit of being able to test the whole feature locally without breaking the main branch.

hmdhk · 2021-03-08T10:38:45Z

I've created feat-angular branch, feel free to merge into that one, I will also checkout that branch to run your changes locally. This way if there's a need for releasing from main branch we can still do it without worrying about untested features.

vigneshshanmugam · 2021-03-08T17:32:08Z

Had a offline discussion, we will merge all Angular related changes in to the feat-angular branch and do a test publish run then do a final merge in master before releasing the major.

* feat(rum-angular): add support for angular 9 * chore: set up the ng build toolchain * feat: rewrite the apm module under src/* * chore: set up the testing with ng * chore: make karma:dev work * chore: make karma:coverage work * chore: address review and disable saucelabs * chore: fix local link and coverage test

* feat(rum-angular): add support for angular 9 * chore: set up the ng build toolchain * chore: rewrite the apm module under src/* * chore: set up the testing with ng * chore: make karma:dev work * chore: make karma:coverage work * chore: address review and disable saucelabs * chore: fix local link and coverage test

* feat(rum-angular)!: angular 9-11 support (#971) * feat(rum-angular): add support for angular 9 * chore: set up the ng build toolchain * chore: rewrite the apm module under src/* * chore: set up the testing with ng * chore: make karma:dev work * chore: make karma:coverage work * chore: address review and disable saucelabs * chore: fix local link and coverage test * chore: migrate angular e2e app to ng cli (#974) * chore: migrate angular e2e app to ng cli * chore: make build system work for e2e * chore: make saucelabs work * chore: enable saucelabs test for angular * chore: fix test scripts * chore: target es5 and add browserlist * chore: only run saucelabs test in jenkins * chore: update prod apmserver url * chore: transpile apmservermock correctly * chore: revert jenkinsfile * chore: fix warnings in build * chore(rum-angular): fix build warnings in prod * chore(rum-angular): add prepublish command * chore(release): publish angular - @elastic/apm-rum-angular@2.0.0-alpha.0 * chore(release): publish angular - @elastic/apm-rum-angular@2.0.0-alpha.1 * docs: update angular integration for >9 versions (#1000) * chore: update angular to latest 11.2.5 (#996) * chore(release): publish angular - @elastic/apm-rum-angular@2.0.0-alpha.2 * chore: fix license lint issue

* feat(rum-angular)!: angular 9-11 support (elastic#971) * feat(rum-angular): add support for angular 9 * chore: set up the ng build toolchain * chore: rewrite the apm module under src/* * chore: set up the testing with ng * chore: make karma:dev work * chore: make karma:coverage work * chore: address review and disable saucelabs * chore: fix local link and coverage test * chore: migrate angular e2e app to ng cli (elastic#974) * chore: migrate angular e2e app to ng cli * chore: make build system work for e2e * chore: make saucelabs work * chore: enable saucelabs test for angular * chore: fix test scripts * chore: target es5 and add browserlist * chore: only run saucelabs test in jenkins * chore: update prod apmserver url * chore: transpile apmservermock correctly * chore: revert jenkinsfile * chore: fix warnings in build * chore(rum-angular): fix build warnings in prod * chore(rum-angular): add prepublish command * chore(release): publish angular - @elastic/apm-rum-angular@2.0.0-alpha.0 * chore(release): publish angular - @elastic/apm-rum-angular@2.0.0-alpha.1 * docs: update angular integration for >9 versions (elastic#1000) * chore: update angular to latest 11.2.5 (elastic#996) * chore(release): publish angular - @elastic/apm-rum-angular@2.0.0-alpha.2 * chore: fix license lint issue

vigneshshanmugam added 4 commits February 25, 2021 15:32

feat(rum-angular): add support for angular 9

80ee11e

chore: set up the ng build toolchain

7122024

feat: rewrite the apm module under src/*

048dc3f

chore: set up the testing with ng

279d7b4

vigneshshanmugam marked this pull request as ready for review February 26, 2021 00:20

vigneshshanmugam added 2 commits February 25, 2021 16:45

chore: make karma:dev work

71a0454

chore: make karma:coverage work

293a574

vigneshshanmugam force-pushed the update-angular branch from 1ed2b81 to 293a574 Compare February 26, 2021 01:07

vigneshshanmugam requested a review from hmdhk February 26, 2021 01:13

chriscarpenter12 reviewed Feb 26, 2021

View reviewed changes

packages/rum-angular/src/apm.module.ts Show resolved Hide resolved

packages/rum-angular/src/apm.service.ts Outdated Show resolved Hide resolved

packages/rum-angular/src/apm.service.ts Outdated Show resolved Hide resolved

vigneshshanmugam added 2 commits February 25, 2021 21:42

chore: address review and disable saucelabs

0d023fa

chore: fix local link and coverage test

0058b02

hmdhk reviewed Mar 4, 2021

View reviewed changes

vigneshshanmugam mentioned this pull request Mar 6, 2021

chore: migrate angular e2e app to ng cli #974

Merged

hmdhk changed the title ~~feat(rum-angular): add support for angular 9~~ BREAKING CHANGE(rum-angular): add support for angular 9 Mar 8, 2021

hmdhk changed the base branch from master to feat-angular March 8, 2021 10:40

vigneshshanmugam merged commit b738d76 into elastic:feat-angular Mar 8, 2021

vigneshshanmugam deleted the update-angular branch March 8, 2021 17:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

BREAKING CHANGE(rum-angular): add support for angular 9 #971

BREAKING CHANGE(rum-angular): add support for angular 9 #971

vigneshshanmugam commented Feb 25, 2021 •

edited

Loading

apmmachine commented Feb 25, 2021

apmmachine commented Feb 25, 2021 •

edited

Loading

Build stats

Trends 🧪

`Lint`

vigneshshanmugam commented Feb 26, 2021

chriscarpenter12 commented Feb 26, 2021

chriscarpenter12 left a comment

chriscarpenter12 commented Feb 26, 2021

vigneshshanmugam commented Feb 26, 2021 •

edited

Loading

hmdhk left a comment

hmdhk Mar 4, 2021

vigneshshanmugam Mar 4, 2021

vigneshshanmugam commented Mar 4, 2021

vigneshshanmugam commented Mar 5, 2021

hmdhk commented Mar 8, 2021 •

edited

Loading

hmdhk commented Mar 8, 2021

vigneshshanmugam commented Mar 8, 2021

BREAKING CHANGE(rum-angular): add support for angular 9 #971

BREAKING CHANGE(rum-angular): add support for angular 9 #971

Conversation

vigneshshanmugam commented Feb 25, 2021 • edited Loading

apmmachine commented Feb 25, 2021

📦 Bundlesize report

apmmachine commented Feb 25, 2021 • edited Loading

💔 Build Failed

Build stats

Trends 🧪

Steps errors

Lint

Log output

vigneshshanmugam commented Feb 26, 2021

chriscarpenter12 commented Feb 26, 2021

chriscarpenter12 left a comment

Choose a reason for hiding this comment

chriscarpenter12 commented Feb 26, 2021

vigneshshanmugam commented Feb 26, 2021 • edited Loading

hmdhk left a comment

Choose a reason for hiding this comment

hmdhk Mar 4, 2021

Choose a reason for hiding this comment

vigneshshanmugam Mar 4, 2021

Choose a reason for hiding this comment

vigneshshanmugam commented Mar 4, 2021

vigneshshanmugam commented Mar 5, 2021

hmdhk commented Mar 8, 2021 • edited Loading

hmdhk commented Mar 8, 2021

vigneshshanmugam commented Mar 8, 2021

vigneshshanmugam commented Feb 25, 2021 •

edited

Loading

apmmachine commented Feb 25, 2021 •

edited

Loading

`Lint`

vigneshshanmugam commented Feb 26, 2021 •

edited

Loading

hmdhk commented Mar 8, 2021 •

edited

Loading