Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump apm-data to detect OTel messaging.{system,operation} for transactions #12506

Merged
merged 5 commits into from
Jan 29, 2024

Conversation

carsonip
Copy link
Member

@carsonip carsonip commented Jan 28, 2024

Motivation/summary

Bump apm-data to detect OTel messaging.{system,operation} for transactions

Checklist

For functional changes, consider:

  • Is it observable through the addition of either logging or metrics?
  • Is its use being published in telemetry to enable product improvement?
  • Have system tests been added to avoid regression?

How to test these changes

  • Send a otel span as transaction with messaging.system or messaging.operation without messaging.destination. Ensure that transaction.type is messaging

Related issues

elastic/apm-data#204

@carsonip carsonip requested a review from a team as a code owner January 28, 2024 14:47
Copy link
Contributor

mergify bot commented Jan 28, 2024

This pull request does not have a backport label. Could you fix it @carsonip? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-7.17 is the label to automatically backport to the 7.17 branch.
  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Jan 28, 2024
@carsonip carsonip changed the title Bump apm-data to detect OTel messaging.{system,operation} for transaction Bump apm-data to detect OTel messaging.{system,operation} for transactions Jan 28, 2024
@carsonip carsonip requested a review from simitt January 28, 2024 15:49
@carsonip carsonip enabled auto-merge (squash) January 29, 2024 10:01
@carsonip carsonip merged commit 062c286 into elastic:main Jan 29, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip Skip notification from the automated backport with mergify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants