Add config option to allow for experimental fields. #1961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To ease enabling and indexing experimental features for development for agent developers, a new config option `environment` is added that can be used to send up arbitray information that gets dynamically indexed. Only use this in non-production environments.
|
related elastic/kibana#32185 |
|
Not sure why it is not picking up the PR elastic/kibana#32185 in the test. |
simitt
added a commit
to simitt/kibana
that referenced
this pull request
Mar 4, 2019
|
@graphaelli the PR in Kibana ensuring that those index pattern changes would also be merged to the Index Pattern, let's other test runs fail, as they also test against this PR now. I'd appreciate a review on this PR to make progress with it and get our CI back to green. |
graphaelli
reviewed
Mar 4, 2019
|
@graphaelli thanks for the input. I changed the contract for decoding to also pass in a config option, and now we can immediately drop any left overs in context if they should not be stored. |
graphaelli
reviewed
Mar 5, 2019
graphaelli
reviewed
Mar 6, 2019
|
@graphaelli can I get another round of review on this? |
graphaelli
approved these changes
Mar 11, 2019
simitt
added a commit
to elastic/kibana
that referenced
this pull request
Mar 11, 2019
* [APM] Add experimental root key to index pattern. related to elastic/apm-server#1961
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For easier enabling and indexing experimental features during development, agent developers can now make use of a newly added config option
apm-server.mode. When set toexperimentalarbitray additional information can be set up withincontext.experimentalthat gets dynamically indexed.How can this be used?
In
apm-server.ymlset the flagapm-server.mode: experimentaland send up additional information nested withincontext.experimentalfor spans, transactions or errors.In a follow up we can enable this by default for the integration testing.
Do not use this in production environment! This is solely added for the purpose of enabling building POCs and trying out different approaches during development.
cc @felixbarny