packetbeat/protos{,/amqp}: fix transaction hash size constant (#36723)

The transaction hash size is currently calculated as 2⊕16 (18) which is most likely not what was intended. The code entered the code base in the initial import which does not have an associated review. However, the symbol ^ signifies exponent in other languages, and XOR is almost never what someone would use for defining a constant like this, so it is very likely that the original author intended a 64Ki cache size. (cherry picked from commit df10d97)
elastic · Oct 3, 2023 · 773840d · 773840d
1 parent 10b17d8
commit 773840d
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/CHANGELOG.next.asciidoc b/CHANGELOG.next.asciidoc
@@ -83,6 +83,7 @@ https://github.com/elastic/beats/compare/v7.0.0-alpha2...master[Check the HEAD d
 *Packetbeat*
 
 - Fix panic in HTTP protocol parsing when host header has empty host part. {issue}36497[36497] {issue}36518[36518]
+- Fix default cache size calculation. {pull}36723[36723]
 
 *Winlogbeat*
 

diff --git a/packetbeat/protos/amqp/amqp_structs.go b/packetbeat/protos/amqp/amqp_structs.go
@@ -26,7 +26,7 @@ import (
 type amqpMethod func(*amqpMessage, []byte) (bool, bool)
 
 const (
-	transactionsHashSize = 2 ^ 16
+	transactionsHashSize = 1 << 16
 	transactionTimeout   = 10 * 1e9
 )
 

diff --git a/packetbeat/protos/protos.go b/packetbeat/protos/protos.go
@@ -32,7 +32,7 @@ import (
 )
 
 const (
-	DefaultTransactionHashSize                 = 2 ^ 16
+	DefaultTransactionHashSize                 = 1 << 16
 	DefaultTransactionExpiration time.Duration = 10 * time.Second
 )