packetbeat/protos{,/amqp}: fix transaction hash size constant #36723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efd6
added
bug
Packetbeat
Team:Security-External Integrations
backport-skip
botelastic
bot
added
needs_team
efd6
force-pushed
the
packetbeat_hashsize
branch
from
8a0ad3f
to
afe29fd
Compare
The transaction hash size is currently calculated as 2⊕16 (18) which is most likely not what was intended. The code entered the code base in the initial import which does not have an associated review. However, the symbol ^ signifies exponent in other languages, and XOR is almost never what someone would use for defining a constant like this, so it is very likely that the original author intended a 64Ki cache size.
efd6
force-pushed
the
packetbeat_hashsize
branch
from
afe29fd
to
24f5079
Compare
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. 🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
efd6
added
backport-v7.17.0
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
bhapas
approved these changes
Oct 3, 2023
mergify bot
pushed a commit
that referenced
this pull request
Oct 3, 2023
The transaction hash size is currently calculated as 2⊕16 (18) which is most likely not what was intended. The code entered the code base in the initial import which does not have an associated review. However, the symbol ^ signifies exponent in other languages, and XOR is almost never what someone would use for defining a constant like this, so it is very likely that the original author intended a 64Ki cache size. (cherry picked from commit df10d97)
mergify bot
pushed a commit
that referenced
this pull request
Oct 3, 2023
The transaction hash size is currently calculated as 2⊕16 (18) which is most likely not what was intended. The code entered the code base in the initial import which does not have an associated review. However, the symbol ^ signifies exponent in other languages, and XOR is almost never what someone would use for defining a constant like this, so it is very likely that the original author intended a 64Ki cache size. (cherry picked from commit df10d97)
efd6
added a commit
that referenced
this pull request
Oct 3, 2023
#36730) The transaction hash size is currently calculated as 2⊕16 (18) which is most likely not what was intended. The code entered the code base in the initial import which does not have an associated review. However, the symbol ^ signifies exponent in other languages, and XOR is almost never what someone would use for defining a constant like this, so it is very likely that the original author intended a 64Ki cache size. (cherry picked from commit df10d97) Co-authored-by: Dan Kortschak <90160302+efd6@users.noreply.github.com>
efd6
added a commit
that referenced
this pull request
Oct 3, 2023
#36731) The transaction hash size is currently calculated as 2⊕16 (18) which is most likely not what was intended. The code entered the code base in the initial import which does not have an associated review. However, the symbol ^ signifies exponent in other languages, and XOR is almost never what someone would use for defining a constant like this, so it is very likely that the original author intended a 64Ki cache size. (cherry picked from commit df10d97) Co-authored-by: Dan Kortschak <90160302+efd6@users.noreply.github.com>
Scholar-Li
pushed a commit
to Scholar-Li/beats
that referenced
this pull request
Feb 5, 2024
…c#36723) The transaction hash size is currently calculated as 2⊕16 (18) which is most likely not what was intended. The code entered the code base in the initial import which does not have an associated review. However, the symbol ^ signifies exponent in other languages, and XOR is almost never what someone would use for defining a constant like this, so it is very likely that the original author intended a 64Ki cache size.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
The transaction hash size is currently calculated as 2⊕16 (18) which is most likely not what was intended. The code entered the code base in the initial import which does not have an associated review. However, the symbol ^ signifies exponent in other languages, and XOR is almost never what someone would use for defining a constant like this, so it is very likely that the original author intended a 64Ki cache size.
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs