Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collect CockroachDB node and cluster ids in Metricbeat module #22959

Closed
jsoriano opened this issue Dec 7, 2020 · 3 comments
Closed

Collect CockroachDB node and cluster ids in Metricbeat module #22959

jsoriano opened this issue Dec 7, 2020 · 3 comments
Labels
enhancement Metricbeat Metricbeat module Stalled Team:Service-Integrations Label for the Service Integrations team

Comments

@jsoriano
Copy link
Member

jsoriano commented Dec 7, 2020

CockroachDB has the native concept of node and cluster ids. As a user one may want to filter data per instance or per cluster.

We need to confirm the identifiers to use for each case, some options:

Cluster ID:

  • Using the SQL interface: SELECT value FROM crdb_internal.node_build_info where field = 'ClusterID';

Node ID:

  • Using the SQL interface:
    • SELECT value FROM crdb_internal.node_metrics where name = 'node-id';
    • SELECT DISTINCT node_id FROM crdb_internal.node_build_info;
  • In the prometheus response:
    # HELP node_id node ID with labels for advertised RPC and HTTP addresses
    # TYPE node_id gauge
    node_id{advertise_addr="roach1:26257",http_addr="roach1:8080"} 1.0
    

This may be an important change because current CockroachDB module is a light module collecting prometheus exposed metrics, and this may require enriching events with metadata obtained with SQL queries.

Related:

@jsoriano jsoriano added enhancement module Metricbeat Metricbeat Team:Services (Deprecated) Label for the former Integrations-Services team labels Dec 7, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-services (Team:Services)

@jsoriano jsoriano changed the title Collect CockroachDB instance and cluster ids in Metricbeat module Collect CockroachDB node and cluster ids in Metricbeat module Dec 7, 2020
@botelastic
Copy link

botelastic bot commented Jan 27, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@botelastic botelastic bot added the Stalled label Jan 27, 2022
@jlind23 jlind23 added Team:Service-Integrations Label for the Service Integrations team and removed Team:Services (Deprecated) Label for the former Integrations-Services team labels Mar 31, 2022
@botelastic botelastic bot removed the Stalled label Mar 31, 2022
@botelastic
Copy link

botelastic bot commented Mar 31, 2023

Hi!
We just realized that we haven't looked into this issue in a while. We're sorry!

We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1.
Thank you for your contribution!

@botelastic botelastic bot added the Stalled label Mar 31, 2023
@botelastic botelastic bot closed this as completed Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Metricbeat Metricbeat module Stalled Team:Service-Integrations Label for the Service Integrations team
Projects
None yet
Development

No branches or pull requests

3 participants