Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GCP metrics: Missing ECS labels when using exclude_labels: true #40437

Closed
gpop63 opened this issue Aug 5, 2024 · 1 comment · Fixed by #40467
Closed

GCP metrics: Missing ECS labels when using exclude_labels: true #40437

gpop63 opened this issue Aug 5, 2024 · 1 comment · Fixed by #40467
Assignees
Labels
needs_team Indicates that the issue/PR needs a Team:* label

Comments

@gpop63
Copy link
Contributor

gpop63 commented Aug 5, 2024

The GCP metrics metricset's exclude_labels: true option causes an issue in the groupTimeSeries function. The default metadata collector is created as a value, preventing the function from initializing metadataService with the correct time series data. This results in missing important labels like cloud.instance.id in the events. To fix this, metadataService should be initially set to nil, allowing initialization based on the time series parameter.

var metadataService gcp.MetadataService
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Aug 5, 2024
@botelastic
Copy link

botelastic bot commented Aug 5, 2024

This issue doesn't have a Team:<team> label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs_team Indicates that the issue/PR needs a Team:* label
Projects
None yet
2 participants