Include date separator in the filename prefix of dateRotator to make sure nothing gets purged accidentally
#26176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
the
needs_team
kvch
force-pushed
the
fix-agent-do-not-purge-binary
branch
from
6fa9d32
to
363df47
Compare
❕ Build Aborted
Expand to view the summary
Build stats
Trends 🧪Log outputExpand to view the last 100 lines of log output
|
kvch
changed the title
dateRotator to make sure nothing gets purged accidentally
michalpristas
approved these changes
Jun 7, 2021
kvch
added
backport-v7.13.0
|
Pinging @elastic/agent (Team:Agent) |
botelastic
bot
removed
the
needs_team
mergify bot
pushed a commit
that referenced
this pull request
Jun 7, 2021
…e sure nothing gets purged accidentally (#26176) ## What does this PR do? This PR changes the log file prefix when using date rotation in Beats. Previously the `-` was not included, so in the list of rotated files every file that started with the configured file prefix were included. ## Why is it important? If the binary is under the same path as the value configured in `logging.files.path` and `logging.files.name`, when the number of rotated log files gets bigger than the one configured in `loggin.files.keepfiles`, the binary is purged on rotation. The workaround is to put the log files in a separate folder. (cherry picked from commit 447bac9)
mergify bot
pushed a commit
that referenced
this pull request
Jun 7, 2021
…e sure nothing gets purged accidentally (#26176) ## What does this PR do? This PR changes the log file prefix when using date rotation in Beats. Previously the `-` was not included, so in the list of rotated files every file that started with the configured file prefix were included. ## Why is it important? If the binary is under the same path as the value configured in `logging.files.path` and `logging.files.name`, when the number of rotated log files gets bigger than the one configured in `loggin.files.keepfiles`, the binary is purged on rotation. The workaround is to put the log files in a separate folder. (cherry picked from commit 447bac9)
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
kvch
added a commit
that referenced
this pull request
Jun 8, 2021
…e sure nothing gets purged accidentally (#26176) ## What does this PR do? This PR changes the log file prefix when using date rotation in Beats. Previously the `-` was not included, so in the list of rotated files every file that started with the configured file prefix were included. ## Why is it important? If the binary is under the same path as the value configured in `logging.files.path` and `logging.files.name`, when the number of rotated log files gets bigger than the one configured in `loggin.files.keepfiles`, the binary is purged on rotation. The workaround is to put the log files in a separate folder. (cherry picked from commit 447bac9)
kvch
added a commit
that referenced
this pull request
Jun 8, 2021
…e sure nothing gets purged accidentally (#26176) ## What does this PR do? This PR changes the log file prefix when using date rotation in Beats. Previously the `-` was not included, so in the list of rotated files every file that started with the configured file prefix were included. ## Why is it important? If the binary is under the same path as the value configured in `logging.files.path` and `logging.files.name`, when the number of rotated log files gets bigger than the one configured in `loggin.files.keepfiles`, the binary is purged on rotation. The workaround is to put the log files in a separate folder. (cherry picked from commit 447bac9)
kvch
added a commit
that referenced
this pull request
Jun 8, 2021
…e sure nothing gets purged accidentally (#26176) (#26179) ## What does this PR do? This PR changes the log file prefix when using date rotation in Beats. Previously the `-` was not included, so in the list of rotated files every file that started with the configured file prefix were included. ## Why is it important? If the binary is under the same path as the value configured in `logging.files.path` and `logging.files.name`, when the number of rotated log files gets bigger than the one configured in `loggin.files.keepfiles`, the binary is purged on rotation. The workaround is to put the log files in a separate folder. (cherry picked from commit 447bac9) Co-authored-by: Noémi Ványi <kvch@users.noreply.github.com>
kvch
added a commit
that referenced
this pull request
Jun 8, 2021
…e sure nothing gets purged accidentally (#26176) (#26178) ## What does this PR do? This PR changes the log file prefix when using date rotation in Beats. Previously the `-` was not included, so in the list of rotated files every file that started with the configured file prefix were included. ## Why is it important? If the binary is under the same path as the value configured in `logging.files.path` and `logging.files.name`, when the number of rotated log files gets bigger than the one configured in `loggin.files.keepfiles`, the binary is purged on rotation. The workaround is to put the log files in a separate folder. (cherry picked from commit 447bac9) Co-authored-by: Noémi Ványi <kvch@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR changes the log file prefix when using date rotation in Beats. Previously the
-was not included, so in the list of rotated files every file that started with the configured file prefix were included.Why is it important?
If the binary is under the same path as the value configured in
logging.files.pathandlogging.files.name, when the number of rotated log files gets bigger than the one configured inloggin.files.keepfiles, the binary is purged on rotation.The workaround is to put the log files in a separate folder.
Checklist
- [ ] I have commented my code, particularly in hard-to-understand areas- [ ] I have made corresponding changes to the documentation- [ ] I have made corresponding change to the default configuration files- [ ] I have added tests that prove my fix is effective or that my feature worksCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.