Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

winlogbeat metrics - Set input type as "winlog" #34886

Merged

Conversation

andrewkroh
Copy link
Member

What does this PR do?

Identify the Windows event log readers as input type winlog in metrics published through the /inputs/ API.

Fixes #34885

Why is it important?

This gives the input a consistent type name in the /inputs/ API data.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Identify the Windows event log readers as input type `winlog` in metrics published
through the /inputs/ API.

Fixes elastic#34885
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Mar 21, 2023
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-03-21T21:49:40.825+0000

  • Duration: 39 min 22 sec

Test stats 🧪

Test Results
Failed 0
Passed 930
Skipped 9
Total 939

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@andrewkroh andrewkroh merged commit d8a9ec4 into elastic:main Mar 21, 2023
mergify bot pushed a commit that referenced this pull request Mar 21, 2023
Identify the Windows event log readers as input type `winlog` in metrics published
through the /inputs/ API.

Fixes #34885

(cherry picked from commit d8a9ec4)
andrewkroh added a commit that referenced this pull request Mar 22, 2023
Identify the Windows event log readers as input type `winlog` in metrics published
through the /inputs/ API.

Fixes #34885

(cherry picked from commit d8a9ec4)

Co-authored-by: Andrew Kroh <andrew.kroh@elastic.co>
chrisberkhout pushed a commit that referenced this pull request Jun 1, 2023
Identify the Windows event log readers as input type `winlog` in metrics published
through the /inputs/ API.

Fixes #34885
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v8.7.0 Automated backport with mergify bug Winlogbeat
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Winlogbeat/Filebeat] Input metrics should contain "winlog" input name
3 participants