Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Heartbeat] Fix mapping for state.ends.id #34891

Merged
merged 4 commits into from Mar 22, 2023
Merged

[Heartbeat] Fix mapping for state.ends.id #34891

merged 4 commits into from Mar 22, 2023

Conversation

andrewvc
Copy link
Contributor

The mapping for state.ends.id should match state.id, with both being a keyword, since IDs are strings.

@andrewvc andrewvc added bug Heartbeat Team:obs-ds-hosted-services Label for the Observability Hosted Services team v8.7.0 backport-v8.7.0 Automated backport with mergify labels Mar 22, 2023
@andrewvc andrewvc requested a review from a team as a code owner March 22, 2023 01:17
@andrewvc andrewvc self-assigned this Mar 22, 2023
@elasticmachine
Copy link
Collaborator

Pinging @elastic/uptime (Team:Uptime)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Mar 22, 2023
vigneshshanmugam
vigneshshanmugam approved these changes Mar 22, 2023
View reviewed changes
Copy link
Member

@vigneshshanmugam vigneshshanmugam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link
Collaborator

elasticmachine commented Mar 22, 2023 •
edited by jenkins-beats-ci bot

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-03-22T01:30:28.163+0000

  • Duration: 49 min 35 sec

Test stats 🧪

Test Results
Failed 0
Passed 1921
Skipped 25
Total 1946

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@andrewvc andrewvc merged commit 210f593 into elastic:main Mar 22, 2023
25 checks passed
@andrewvc andrewvc deleted the fix-state-id-mapping branch March 22, 2023 02:27
mergify bot pushed a commit that referenced this pull request Mar 22, 2023
@andrewvc @mergify
[Heartbeat] Fix mapping for state.ends.id (#34891)
7bc3695 
The mapping for state.ends.id should match state.id, with both being a keyword, since IDs are strings.

(cherry picked from commit 210f593)
@mergify mergify bot mentioned this pull request Mar 22, 2023
Merged
andrewvc added a commit that referenced this pull request Mar 22, 2023
@mergify @andrewvc
[Heartbeat] Fix mapping for state.ends.id (#34891) (#34892)
b2f6378 
The mapping for state.ends.id should match state.id, with both being a keyword, since IDs are strings.

(cherry picked from commit 210f593)

Co-authored-by: Andrew Cholakian <andrewvc@elastic.co>
chrisberkhout pushed a commit that referenced this pull request Jun 1, 2023
@andrewvc @chrisberkhout
[Heartbeat] Fix mapping for state.ends.id (#34891)
996abbc 
The mapping for state.ends.id should match state.id, with both being a keyword, since IDs are strings.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vigneshshanmugam vigneshshanmugam vigneshshanmugam approved these changes

Assignees

@andrewvc andrewvc

Labels
backport-v8.7.0 Automated backport with mergify bug Heartbeat Team:obs-ds-hosted-services Label for the Observability Hosted Services team v8.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@andrewvc @elasticmachine @vigneshshanmugam