Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade elastic-agent-system-metrics to v0.8.2 #37171

Merged
merged 3 commits into from Nov 21, 2023
Merged

upgrade elastic-agent-system-metrics to v0.8.2 #37171

merged 3 commits into from Nov 21, 2023

Conversation

leehinman
Copy link
Contributor

Proposed commit message

upgrade elastic-agent-system-metrics to v0.8.2

This is to fix a memory leak on Windows platform where process snapshots were not being freed.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

  1. Install metricbeat 8.11.0 on Windows, collect process metrics
  2. notice memory consumption continues to climb (~30 min is required to see) in Task Manager
  3. rebuild with this PR
  4. test again, memory consumption will go up and down

Related issues

Use cases

Screenshots

Logs

@leehinman leehinman added Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team bugfix backport-v8.11.0 Automated backport with mergify labels Nov 21, 2023
@leehinman leehinman requested a review from a team as a code owner November 21, 2023 19:24
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Nov 21, 2023
@elasticmachine
Copy link
Collaborator

❕ Build Aborted

There is a new build on-going so the previous on-going builds have been aborted.

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Start Time: 2023-11-21T19:24:53.130+0000

  • Duration: 6 min 35 sec

Steps errors 1

Expand to view the steps failures

Error signal
  • Took 0 min 0 sec . View more details here
  • Description: tar: step failed with error null

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@elasticmachine
Copy link
Collaborator

❕ Build Aborted

There is a new build on-going so the previous on-going builds have been aborted.

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Start Time: 2023-11-21T19:25:53.158+0000

  • Duration: 11 min 46 sec

Test stats 🧪

Test Results
Failed 0
Passed 3
Skipped 0
Total 3

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-11-21T19:31:55.606+0000

  • Duration: 163 min 55 sec

Test stats 🧪

Test Results
Failed 0
Passed 28690
Skipped 2015
Total 30705

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@leehinman leehinman merged commit 15857a8 into elastic:main Nov 21, 2023
113 checks passed
mergify bot pushed a commit that referenced this pull request Nov 21, 2023
@leehinman @mergify
upgrade elastic-agent-system-metrics to v0.8.2 (#37171)
9428a1b 
* upgrade elastic-agent-system-metrics to v0.8.2

bugfix for memory leak

(cherry picked from commit 15857a8)

# Conflicts:
#	NOTICE.txt
#	go.mod
#	go.sum
@mergify mergify bot mentioned this pull request Nov 21, 2023
Merged
zmoog pushed a commit that referenced this pull request Nov 28, 2023
@mergify @leehinman
[8.11](backport #37171) upgrade elastic-agent-system-metrics to v0.8.2 (
1ac2770 
#37173)

* upgrade elastic-agent-system-metrics to v0.8.2 (#37171)

* upgrade elastic-agent-system-metrics to v0.8.2

- bugfix for memory leak
- backport system test changes, required by elastic-agent-system-metrics v0.8.1

(cherry picked from commit 15857a8)

Co-authored-by: Lee E Hinman <57081003+leehinman@users.noreply.github.com>
Co-authored-by: Lee E. Hinman <lee.e.hinman@elastic.co>
Scholar-Li pushed a commit to Scholar-Li/beats that referenced this pull request Feb 5, 2024
@leehinman @Scholar-Li
upgrade elastic-agent-system-metrics to v0.8.2 (elastic#37171)
040e329 
* upgrade elastic-agent-system-metrics to v0.8.2

bugfix for memory leak
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewkroh andrewkroh andrewkroh approved these changes

Assignees

@leehinman leehinman

Labels
backport-v8.11.0 Automated backport with mergify bugfix Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[metricbeat] memory leak 10GB RAM usage and crash, urgent solution needed
3 participants
@leehinman @elasticmachine @andrewkroh