Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.11](backport #37171) upgrade elastic-agent-system-metrics to v0.8.2 #37173

Merged
merged 3 commits into from
Nov 22, 2023

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Nov 21, 2023

This is an automatic backport of pull request #37171 done by Mergify.
Cherry-pick of 15857a8 has failed:

On branch mergify/bp/8.11/pr-37171
Your branch is up to date with 'origin/8.11'.

You are currently cherry-picking commit 15857a8596.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   CHANGELOG.next.asciidoc

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   NOTICE.txt
	both modified:   go.mod
	both modified:   go.sum

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

* upgrade elastic-agent-system-metrics to v0.8.2

bugfix for memory leak

(cherry picked from commit 15857a8)

# Conflicts:
#	NOTICE.txt
#	go.mod
#	go.sum
@mergify mergify bot requested a review from a team as a code owner November 21, 2023 22:54
@mergify mergify bot added backport conflicts There is a conflict in the backported pull request labels Nov 21, 2023
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Nov 21, 2023
@elasticmachine
Copy link
Collaborator

💔 Build Failed

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-11-21T22:54:34.280+0000

  • Duration: 6 min 21 sec

Steps errors 1

Expand to view the steps failures

Shell Script
  • Took 0 min 7 sec . View more details here
  • Description: HOME=/var/lib/jenkins/workspace/Beats_beats_PR-37173 GO_VERSION=1.20.11 ./dev-tools/run_with_go_ver make test-mage

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@elasticmachine
Copy link
Collaborator

💔 Tests Failed

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-11-21T23:55:30.781+0000

  • Duration: 81 min 16 sec

Test stats 🧪

Test Results
Failed 2
Passed 28467
Skipped 2013
Total 30482

Test errors 2

Expand to view the tests failures

Build&Test / metricbeat-windows-2016-windows-2016 / test_process – metricbeat.module.system.test_system.Test
    Expand to view the error details

     AssertionError: Element counts were not equal:
    First has 1, Second has 0:  'num_threads' 
    

    Expand to view the stacktrace

     self = <test_system.Test testMethod=test_process>
    
        @unittest.skipUnless(re.match("(?i)win|linux|darwin|freebsd", sys.platform), "os")
        def test_process(self):
            """
            Test system/process output.
            """
            self.render_config_template(modules=[{
                "name": "system",
                "metricsets": ["process"],
                "period": "5s",
                "extras": {
                    "process.env.whitelist": ["PATH"],
                    "process.include_cpu_ticks": True,
        
                    # Remove 'percpu' prior to checking documented fields because its keys are dynamic.
                    "process.include_per_cpu": False,
                }
            }])
            self.run_beat_and_stop()
        
            output = self.read_output_json()
            self.assertGreater(len(output), 0)
        
            found_cmdline = False
            for evt in output:
                process = evt["system"]["process"]
                found_cmdline |= "cmdline" in process
        
                # Remove 'env' prior to checking documented fields because its keys are dynamic.
                process.pop("env", None)
                self.assert_fields_are_documented(evt)
        
                # Remove optional keys.
                process.pop("cgroup", None)
                process.pop("fd", None)
                process.pop("cmdline", None)
        
    >           self.assertCountEqual(SYSTEM_PROCESS_FIELDS, process.keys())
    E           AssertionError: Element counts were not equal:
    E           First has 1, Second has 0:  'num_threads'
    
    module\system\test_system.py:434: AssertionError 
    

Build&Test / metricbeat-windows-2022-windows-2022 / test_process – metricbeat.module.system.test_system.Test
    Expand to view the error details

     AssertionError: Element counts were not equal:
    First has 1, Second has 0:  'num_threads' 
    

    Expand to view the stacktrace

     self = <test_system.Test testMethod=test_process>
    
        @unittest.skipUnless(re.match("(?i)win|linux|darwin|freebsd", sys.platform), "os")
        def test_process(self):
            """
            Test system/process output.
            """
            self.render_config_template(modules=[{
                "name": "system",
                "metricsets": ["process"],
                "period": "5s",
                "extras": {
                    "process.env.whitelist": ["PATH"],
                    "process.include_cpu_ticks": True,
        
                    # Remove 'percpu' prior to checking documented fields because its keys are dynamic.
                    "process.include_per_cpu": False,
                }
            }])
            self.run_beat_and_stop()
        
            output = self.read_output_json()
            self.assertGreater(len(output), 0)
        
            found_cmdline = False
            for evt in output:
                process = evt["system"]["process"]
                found_cmdline |= "cmdline" in process
        
                # Remove 'env' prior to checking documented fields because its keys are dynamic.
                process.pop("env", None)
                self.assert_fields_are_documented(evt)
        
                # Remove optional keys.
                process.pop("cgroup", None)
                process.pop("fd", None)
                process.pop("cmdline", None)
        
    >           self.assertCountEqual(SYSTEM_PROCESS_FIELDS, process.keys())
    E           AssertionError: Element counts were not equal:
    E           First has 1, Second has 0:  'num_threads'
    
    module\system\test_system.py:434: AssertionError 
    

Steps errors 9

Expand to view the steps failures

filebeat-goIntegTest - mage goIntegTest
  • Took 4 min 58 sec . View more details here
  • Description: mage goIntegTest
metricbeat-pythonIntegTest - mage pythonIntegTest
  • Took 33 min 48 sec . View more details here
  • Description: mage pythonIntegTest
metricbeat-windows-2022-windows-2022 - mage build unitTest
  • Took 9 min 39 sec . View more details here
  • Description: mage build unitTest
metricbeat-windows-2022-windows-2022 - mage build unitTest
  • Took 4 min 31 sec . View more details here
  • Description: mage build unitTest
metricbeat-windows-2022-windows-2022 - mage build unitTest
  • Took 4 min 32 sec . View more details here
  • Description: mage build unitTest
metricbeat-windows-2016-windows-2016 - mage build unitTest
  • Took 9 min 30 sec . View more details here
  • Description: mage build unitTest
metricbeat-windows-2016-windows-2016 - mage build unitTest
  • Took 4 min 36 sec . View more details here
  • Description: mage build unitTest
metricbeat-windows-2016-windows-2016 - mage build unitTest
  • Took 4 min 34 sec . View more details here
  • Description: mage build unitTest
Error signal
  • Took 0 min 0 sec . View more details here
  • Description: Error 'hudson.AbortException: script returned exit code 1'

🐛 Flaky test report

❕ There are test failures but not known flaky tests.

Expand to view the summary

Genuine test errors 2

💔 There are test failures but not known flaky tests, most likely a genuine test failure.

  • Name: Build&Test / metricbeat-windows-2016-windows-2016 / test_process – metricbeat.module.system.test_system.Test
  • Name: Build&Test / metricbeat-windows-2022-windows-2022 / test_process – metricbeat.module.system.test_system.Test

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@pierrehilbert pierrehilbert added the Team:Elastic-Agent Label for the Agent team label Nov 22, 2023
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Nov 22, 2023
required by elastic-agent-system-metrics v0.8.1
@leehinman leehinman requested a review from a team as a code owner November 22, 2023 15:06
@leehinman leehinman requested review from faec and removed request for a team November 22, 2023 15:06
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-11-22T15:07:21.466+0000

  • Duration: 121 min 17 sec

Test stats 🧪

Test Results
Failed 0
Passed 27939
Skipped 1880
Total 29819

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@leehinman leehinman merged commit 1ac2770 into 8.11 Nov 22, 2023
117 checks passed
@leehinman leehinman deleted the mergify/bp/8.11/pr-37171 branch November 22, 2023 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport conflicts There is a conflict in the backported pull request Team:Elastic-Agent Label for the Agent team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants