-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove event fields from error log. #37330
Conversation
Remove event fields from error log when the script processor panics. This is an unlikely situation to happen as the Javascript runtime we use should not panic on any error while executing Javascript code, hence the event fields are just removed.
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you.
@belimawr could you please take care of the linter issues? |
@pierrehilbert @cmacknz this needs to be merged asap, we should probably follow up with the linter issue afterwards. |
Remove event fields from error log when the script processor panics. This is an unlikely situation to happen as the Javascript runtime we use should not panic on any error while executing Javascript code, hence the event fields are just removed. (cherry picked from commit 3a504dd) # Conflicts: # libbeat/processors/script/javascript/session.go
Remove event fields from error log when the script processor panics. This is an unlikely situation to happen as the Javascript runtime we use should not panic on any error while executing Javascript code, hence the event fields are just removed. (cherry picked from commit 3a504dd)
Remove event fields from error log when the script processor panics. This is an unlikely situation to happen as the Javascript runtime we use should not panic on any error while executing Javascript code, hence the event fields are just removed. (cherry picked from commit 3a504dd)
Remove event fields from error log when the script processor panics. This is an unlikely situation to happen as the Javascript runtime we use should not panic on any error while executing Javascript code, hence the event fields are just removed. (cherry picked from commit 3a504dd) Co-authored-by: Tiago Queiroz <tiago.queiroz@elastic.co>
* Remove event fields from error log. (#37330) Remove event fields from error log when the script processor panics. This is an unlikely situation to happen as the Javascript runtime we use should not panic on any error while executing Javascript code, hence the event fields are just removed. (cherry picked from commit 3a504dd) # Conflicts: # libbeat/processors/script/javascript/session.go * Fix conflict in libbeat/processors/script/javascript/session.go --------- Co-authored-by: Tiago Queiroz <tiago.queiroz@elastic.co> Co-authored-by: Craig MacKenzie <craig.mackenzie@elastic.co>
Remove event fields from error log when the script processor panics. This is an unlikely situation to happen as the Javascript runtime we use should not panic on any error while executing Javascript code, hence the event fields are just removed. (cherry picked from commit 3a504dd) Co-authored-by: Tiago Queiroz <tiago.queiroz@elastic.co> Co-authored-by: Craig MacKenzie <craig.mackenzie@elastic.co>
Remove event fields from error log when the script processor panics. This is an unlikely situation to happen as the Javascript runtime we use should not panic on any error while executing Javascript code, hence the event fields are just removed.
Proposed commit message
Remove event fields from error log when the script processor panics. This is an unlikely situation to happen as the Javascript runtime we use should not panic on any error while executing Javascript code, hence the event fields are just removed.
Checklist
- [ ] I have commented my code, particularly in hard-to-understand areas- [ ] I have made corresponding changes to the documentation- [ ] I have made corresponding change to the default configuration files- [ ] I have added tests that prove my fix is effective or that my feature works- [ ] I have added an entry inCHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.## Author's Checklist## How to test this PR locally## Related issues## Use cases## Screenshots## Logs