Remove event fields from error log. #37330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove event fields from error log when the script processor panics. This is an unlikely situation to happen as the Javascript runtime we use should not panic on any error while executing Javascript code, hence the event fields are just removed.
botelastic
bot
added
needs_team
|
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
belimawr
added
backport-v7.17.0
💚 Build Succeeded
Expand to view the summary
Build stats
❕ Flaky test reportNo test was executed to be analysed. 🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
|
@belimawr could you please take care of the linter issues? |
|
@pierrehilbert @cmacknz this needs to be merged asap, we should probably follow up with the linter issue afterwards. |
cmacknz
approved these changes
Dec 7, 2023
mergify bot
pushed a commit
that referenced
this pull request
Dec 7, 2023
Remove event fields from error log when the script processor panics. This is an unlikely situation to happen as the Javascript runtime we use should not panic on any error while executing Javascript code, hence the event fields are just removed. (cherry picked from commit 3a504dd) # Conflicts: # libbeat/processors/script/javascript/session.go
mergify bot
pushed a commit
that referenced
this pull request
Dec 7, 2023
Remove event fields from error log when the script processor panics. This is an unlikely situation to happen as the Javascript runtime we use should not panic on any error while executing Javascript code, hence the event fields are just removed. (cherry picked from commit 3a504dd)
mergify bot
pushed a commit
that referenced
this pull request
Dec 7, 2023
Remove event fields from error log when the script processor panics. This is an unlikely situation to happen as the Javascript runtime we use should not panic on any error while executing Javascript code, hence the event fields are just removed. (cherry picked from commit 3a504dd)
This was referenced Dec 7, 2023
cmacknz
pushed a commit
that referenced
this pull request
Dec 7, 2023
Remove event fields from error log when the script processor panics. This is an unlikely situation to happen as the Javascript runtime we use should not panic on any error while executing Javascript code, hence the event fields are just removed. (cherry picked from commit 3a504dd) Co-authored-by: Tiago Queiroz <tiago.queiroz@elastic.co>
cmacknz
added a commit
that referenced
this pull request
Dec 8, 2023
* Remove event fields from error log. (#37330) Remove event fields from error log when the script processor panics. This is an unlikely situation to happen as the Javascript runtime we use should not panic on any error while executing Javascript code, hence the event fields are just removed. (cherry picked from commit 3a504dd) # Conflicts: # libbeat/processors/script/javascript/session.go * Fix conflict in libbeat/processors/script/javascript/session.go --------- Co-authored-by: Tiago Queiroz <tiago.queiroz@elastic.co> Co-authored-by: Craig MacKenzie <craig.mackenzie@elastic.co>
cmacknz
added a commit
that referenced
this pull request
Dec 12, 2023
Remove event fields from error log when the script processor panics. This is an unlikely situation to happen as the Javascript runtime we use should not panic on any error while executing Javascript code, hence the event fields are just removed. (cherry picked from commit 3a504dd) Co-authored-by: Tiago Queiroz <tiago.queiroz@elastic.co> Co-authored-by: Craig MacKenzie <craig.mackenzie@elastic.co>
Scholar-Li
pushed a commit
to Scholar-Li/beats
that referenced
this pull request
Feb 5, 2024
Remove event fields from error log when the script processor panics. This is an unlikely situation to happen as the Javascript runtime we use should not panic on any error while executing Javascript code, hence the event fields are just removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Remove event fields from error log when the script processor panics. This is an unlikely situation to happen as the Javascript runtime we use should not panic on any error while executing Javascript code, hence the event fields are just removed.
Checklist
- [ ] I have commented my code, particularly in hard-to-understand areas- [ ] I have made corresponding changes to the documentation- [ ] I have made corresponding change to the default configuration files- [ ] I have added tests that prove my fix is effective or that my feature works- [ ] I have added an entry inCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.## Author's Checklist## How to test this PR locally## Related issues## Use cases## Screenshots## Logs