Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable macOS arm tests for x-pack/filebeat #39665

Merged
merged 3 commits into from
May 24, 2024

Conversation

oakrizan
Copy link
Contributor

@oakrizan oakrizan commented May 22, 2024

Proposed commit message

Enabled macOS arm tests for x-pack/filebeat on Buildkite as it was in Jenkins. After orka macOS agent adjustments & retry enabling tests seems to be working.
Shouldn't be backported to 7.17, since there is no macOS arm step in Jenkins for 7.17.
Jenkins vs. Buildkite comparison: https://gist.github.com/oakrizan/0ef4a4df595547489538cbbc0ad1a4e5

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • .buildkite/x-pack/pipeline.xpack.filebeat.yml

Related issues

Logs

BK builds: https://buildkite.com/elastic/beats-xpack-filebeat/builds?branch=oakrizan%3Axpack-filebet-enable-macos-arm-tests

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label May 22, 2024
@oakrizan oakrizan added the macOS Enable builds in the CI for darwin testing label May 22, 2024
@oakrizan
Copy link
Contributor Author

/test

Copy link
Contributor

mergify bot commented May 22, 2024

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @oakrizan? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@oakrizan oakrizan force-pushed the xpack-filebet-enable-macos-arm-tests branch from bc1850d to eadb4ab Compare May 22, 2024 12:47
@oakrizan oakrizan added backport-v8.13.0 Automated backport with mergify Team:Ingest-EngProd backport-v8.14.0 Automated backport with mergify labels May 23, 2024
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label May 23, 2024
@oakrizan oakrizan added the ci label May 23, 2024
@oakrizan oakrizan marked this pull request as ready for review May 23, 2024 10:37
@oakrizan oakrizan requested a review from a team as a code owner May 23, 2024 10:37
@oakrizan oakrizan merged commit 67ad3d0 into elastic:main May 24, 2024
17 checks passed
mergify bot pushed a commit that referenced this pull request May 24, 2024
Enabled macOS arm tests for x-pack/filebeat on Buildkite as it was in Jenkins

(cherry picked from commit 67ad3d0)
mergify bot pushed a commit that referenced this pull request May 24, 2024
Enabled macOS arm tests for x-pack/filebeat on Buildkite as it was in Jenkins

(cherry picked from commit 67ad3d0)
oakrizan pushed a commit that referenced this pull request May 24, 2024
Enabled macOS arm tests for x-pack/filebeat on Buildkite as it was in Jenkins
oakrizan pushed a commit that referenced this pull request May 24, 2024
Enabled macOS arm tests for x-pack/filebeat on Buildkite as it was in Jenkins
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v8.13.0 Automated backport with mergify backport-v8.14.0 Automated backport with mergify ci macOS Enable builds in the CI for darwin testing Team:Ingest-EngProd
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants