Make kubernetes autodiscover ignore events with empty container IDs #7971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vjsamuel
force-pushed
the
remove_empty_cid
branch
from
f272de1
to
0f753f3
Compare
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
vjsamuel
force-pushed
the
remove_empty_cid
branch
from
0f753f3
to
4eda8ae
Compare
|
jenkins, test this |
exekias
added
needs_backport
exekias
pushed a commit
to exekias/beats
that referenced
this pull request
Aug 23, 2018
…lastic#7971) (cherry picked from commit 9095426)
exekias
added
v6.4.0
and removed
needs_backport
exekias
pushed a commit
to exekias/beats
that referenced
this pull request
Aug 23, 2018
…lastic#7971) (cherry picked from commit 9095426)
andrewvc
pushed a commit
that referenced
this pull request
Aug 23, 2018
jsoriano
pushed a commit
that referenced
this pull request
Aug 24, 2018
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…lastic#7971) (elastic#8064) (cherry picked from commit 405f575)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are scenarios where filebeat/metricbeat come up before the container is marked as
Running. This would mean that the container's ID would not be persisted in thePodobject. With autodiscover has an infinite retry which keeps retrying the failed configuration even after another event was generated with the container ID.This PR makes sure that an event without a container ID is ignored as neither filebeat nor metricbeat would have any use for it. Both would spin up a config after the container ID is available.