Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin resource's plugin_dir should have a sensible default #345

Closed
michaelklishin opened this issue Jul 16, 2015 · 1 comment

Comments

Projects
None yet
2 participants
@michaelklishin
Copy link
Contributor

commented Jul 16, 2015

README examples and even code comments use usr/local/awesome/elasticsearch-version/plugins as a plugin_dir value. I'm not sure if that's a real world example or not. Surely ElasticSearch provides a standard plugins directory: why doesn't this cookbook have a default for that? Why do the users have to even think about where to put the plugins?

@martinb3

This comment has been minimized.

Copy link
Contributor

commented Jul 16, 2015

Have you tried to use the elasticsearch_plugin with the defaults? It actually does default to the typical path. This cookbook was written to handle a very commonly requested case of multiple instances per server. We'll try to provide better documentation in the future.

@martinb3 martinb3 added this to the 1.0.x bugfix release milestone Jul 16, 2015

martinb3 added a commit that referenced this issue Jul 17, 2015

Test simple plugin install as part of default
- Test default simple plugin install as part of default test suite.
- Add example using the test to the documentation. Add more simple examples to the README.md, demonstrating the defaults. RE: #345

martinb3 added a commit that referenced this issue Jul 17, 2015

Test simple plugin install as part of default
- Test default simple plugin install as part of default test suite.
- Add example using the test to the documentation. Add more simple examples to the README.md, demonstrating the defaults. RE: #345
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.