allow options passing to package provider

[scalp42]

Hi @karmi

If you install 1.5.0 and try to update the provider version/url to point to 1.6.0 for example, assuming that you match the conf path with the one from the elastic package (/etc/elasticsearch), then you need to be able to pass something like this:

"--force-yes -o Dpkg::Options::='--force-confold'"

Thanks for looking at it, without it there's no way to be able to update nodes in place currently.

[scalp42]

How to reproduce:

elasticsearch_install 'elasticsearch' do
  type :package
  version '1.5.0'
  package_url %|https://download.elastic.co/elasticsearch/elasticsearch/elasticsearch-1.5.0.deb|
  action :install
end

elasticsearch_configure 'elasticsearch' do
  path_conf '/etc/elasticsearch'
  path_data '/elasticsearch'
  path_logs '/var/log/elasticsearch'
  es_home '/usr/share'
end

Run Chef, then change just the version to 1.6.0:

elasticsearch_install 'elasticsearch' do
  type :package
  version '1.6.0'
  package_url %|https://download.elastic.co/elasticsearch/elasticsearch/elasticsearch-1.6.0.deb|
  package_checksum "ac3b84b355234e491fbaaa9e27bcd4be1304fcfd36bb8a1c7ce9920f77c727ad"
  action :install
end

Chef will fail as dpkg will need to be told what to do about the previous configuration files.

This PR will bring the fix:

elasticsearch_install 'elasticsearch' do
  type :package
  version '1.6.0'
  package_url %|https://download.elastic.co/elasticsearch/elasticsearch/elasticsearch-1.6.0.deb|
  package_checksum "ac3b84b355234e491fbaaa9e27bcd4be1304fcfd36bb8a1c7ce9920f77c727ad"
  action :install
  package_options %q|--force-yes -o Dpkg::Options::='--force-confold'|
end

[martinb3]

Thank you for catching this!

[martinb3]

Just a heads up -- this actually breaks for the dpkg version. I'm not sure why CI didn't fail this, but converging the cookbook now fails on some of the test suites.