-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[New Rules] Scheduler 1.4.x #16
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kfirpeled
requested changes
Nov 25, 2021
# Conflicts: # compliance/lib/common.rego # compliance/lib/data_adapter.rego
kfirpeled
reviewed
Dec 1, 2021
@@ -10,6 +10,12 @@ filesystem_input(filename, mode, uid, gid) = { | |||
"gid": gid, | |||
} | |||
|
|||
# Recivies an array of arguments representing the kube-scheduler command | |||
scheduler_input(process_type, arguments) = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO scheduler_input
should not get process_type
that is a well known value. why should it be anything else?
kfirpeled
approved these changes
Dec 1, 2021
orestisfl
pushed a commit
that referenced
this pull request
Oct 11, 2023
orestisfl
pushed a commit
to orestisfl/csp-security-policies
that referenced
this pull request
Oct 12, 2023
elastic#16 ---NOTE--- This is an imported commit, it was initially committed to the csp-security-policies repo which was then merged into cloudbeat. See: elastic/cloudbeat#1405
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
new rules: