init: Provide alternative API validation call (#197)

Changes the message returned when the API call to validate the API key
cannot be made, and tries a different api (GET /deployments) before
returning a more curated error.

Signed-off-by: Marc Lopez <marc5.12@outlook.com>

Author: marclop

pkg/ecctl/init.go

@@ -28,6 +28,7 @@ import (
 	"strconv"
 	"strings"
 
+	"github.com/elastic/ecctl/pkg/deployment"
 	"github.com/elastic/ecctl/pkg/user"
 
 	"github.com/elastic/cloud-sdk-go/pkg/input"
@@ -102,7 +103,9 @@ const (
 	//nolint
 	passMsg = "Type in your password: "
 
-	validCredentialsMsg = "Your credentials seem to be valid, and show you're authenticated as \"%s\".\n\n"
+	validCredentialsMsg            = "Your credentials seem to be valid, and show you're authenticated as \"%s\".\n\n"
+	validCredentialsAlternativeMsg = "Your credentials seem to be valid.\n\n"
+	invalidCredentialsMsg          = "Your credentials couldn't be validated. Make sure they're correct and try again"
 )
 
 var (
@@ -166,7 +169,6 @@ Please enter a choice: `
 
 	finalMsg = `
 You're all set! Here are some commands to try:
-  $ ecctl auth user key list
   $ ecctl deployment elasticsearch list`[1:]
 
 	// Remove once we have an endpoint available to list regions.
@@ -480,7 +482,14 @@ func validateAuth(cfg Config, writer io.Writer) error {
 
 	u, err := user.GetCurrent(user.GetCurrentParams{API: a.API})
 	if err != nil {
-		return err
+		if _, e := deployment.List(deployment.ListParams{
+			API: a.API,
+		}); e != nil {
+			// nolint
+			return errors.New(invalidCredentialsMsg)
+		}
+		fmt.Fprint(writer, validCredentialsAlternativeMsg)
+		return nil
 	}
 
 	fmt.Fprintf(writer, validCredentialsMsg, *u.UserName)

pkg/ecctl/init_test.go

@@ -306,6 +306,85 @@ func TestInitConfig(t *testing.T) {
 				authChoiceMsg + "\n" + userMsg + passMsg + "\n" + formatChoiceMsg +
 				"\n" + "\n" + fmt.Sprintf(validCredentialsMsg, "auser") + finalMsg + "\n",
 		},
+		{
+			name: "doesn't find a config file and user creates a new one with user/pass, GET user fails, but deployment list succeeds",
+			args: args{params: InitConfigParams{
+				Viper:    emptyViperToCreateConfigUserPass,
+				FilePath: filepath.Join(testFiles, "newConfigUserPass"),
+				Reader: io.MultiReader(
+					strings.NewReader("y\n"),
+					strings.NewReader("2\n"),
+					strings.NewReader("https://ahost\n"),
+					strings.NewReader("2\n"),
+					strings.NewReader("auser\n"),
+					strings.NewReader("1\n"),
+				),
+				Writer:    new(bytes.Buffer),
+				ErrWriter: new(bytes.Buffer),
+				PasswordReadFunc: func(int) ([]byte, error) {
+					return []byte("apassword"), nil
+				},
+				Client: mock.NewClient(
+					mock.New200Response(mock.NewStructBody(models.TokenResponse{
+						Token: ec.String("atoken"),
+					})),
+					mock.New404Response(mock.NewStructBody(models.User{
+						UserName: ec.String("auser"),
+					})),
+					mock.New200Response(mock.NewStructBody(models.DeploymentsListResponse{})),
+				),
+			}},
+			wantSettings: map[string]interface{}{
+				"host":     "https://ahost",
+				"insecure": true,
+				"output":   "text",
+				"pass":     "apassword",
+				"user":     "auser",
+			},
+			wantOutput: disclaimer + missingConfigMsg + hostChoiceMsg + "\n" + eceHostMsg +
+				authChoiceMsg + "\n" + userMsg + passMsg + "\n" + formatChoiceMsg +
+				"\n" + "\n" + validCredentialsAlternativeMsg + finalMsg + "\n",
+		},
+		{
+			name: "doesn't find a config file and user creates a new one with user/pass, and returns error on API test",
+			args: args{params: InitConfigParams{
+				Viper:    emptyViperToCreateConfigUserPass,
+				FilePath: filepath.Join(testFiles, "newConfigUserPass"),
+				Reader: io.MultiReader(
+					strings.NewReader("y\n"),
+					strings.NewReader("2\n"),
+					strings.NewReader("https://ahost\n"),
+					strings.NewReader("2\n"),
+					strings.NewReader("auser\n"),
+					strings.NewReader("1\n"),
+				),
+				Writer:    new(bytes.Buffer),
+				ErrWriter: new(bytes.Buffer),
+				PasswordReadFunc: func(int) ([]byte, error) {
+					return []byte("apassword"), nil
+				},
+				Client: mock.NewClient(
+					mock.New200Response(mock.NewStructBody(models.TokenResponse{
+						Token: ec.String("atoken"),
+					})),
+					mock.New404Response(mock.NewStructBody(models.User{
+						UserName: ec.String("auser"),
+					})),
+					mock.New404Response(mock.NewStructBody(models.DeploymentsListResponse{})),
+				),
+			}},
+			wantSettings: map[string]interface{}{
+				"host":     "https://ahost",
+				"insecure": true,
+				"output":   "text",
+				"pass":     "apassword",
+				"user":     "auser",
+			},
+			err: errors.New(invalidCredentialsMsg),
+			wantOutput: disclaimer + missingConfigMsg + hostChoiceMsg + "\n" + eceHostMsg +
+				authChoiceMsg + "\n" + userMsg + passMsg + "\n" + formatChoiceMsg +
+				"\n" + "\n",
+		},
 		{
 			name: "finds a config file and user changes the values",
 			args: args{params: InitConfigParams{