fix refid discovery and require confirmation (#104)

bug: Fixes a bug where RefID auto-discovery was broken, and adds extra step to confirm the user wishes to perform a destructive action.

Author: karencfv

cmd/deployment/resource/delete.go

@@ -18,6 +18,8 @@
 package cmddeploymentresource
 
 import (
+	"os"
+
 	"github.com/spf13/cobra"
 
 	cmdutil "github.com/elastic/ecctl/cmd/util"
@@ -35,6 +37,12 @@ var deleteCmd = &cobra.Command{
 		resType, _ := cmd.Flags().GetString("type")
 		refID, _ := cmd.Flags().GetString("ref-id")
 
+		force, _ := cmd.Flags().GetBool("force")
+		var msg = "This action will delete a deployment's resource type and its configuration history. Do you want to continue? [y/n]: "
+		if !force && !cmdutil.ConfirmAction(msg, os.Stderr, os.Stdout) {
+			return nil
+		}
+
 		return depresource.DeleteStateless(depresource.DeleteStatelessParams{
 			ResourceParams: deployment.ResourceParams{
 				API:          ecctl.Get().API,

pkg/deployment/depresource/delete_stateless.go

@@ -33,7 +33,7 @@ type DeleteStatelessParams struct {
 }
 
 // Validate ensures the parameters are usable by the consuming function.
-func (params DeleteStatelessParams) Validate() error {
+func (params *DeleteStatelessParams) Validate() error {
 	var merr = new(multierror.Error)
 
 	merr = multierror.Append(merr, params.ResourceParams.Validate())