Correct arguments on ConfirmAction() (#561)

- Use os.Stdin instead of os.Stderr to read user input
- Print question using the configured output instead of hardcoded os.Stdout

Fixes #560

Signed-off-by: Youhei Sakurai <sakurai.youhei@gmail.com>

Author: sakurai-youhei

cmd/deployment/resource/delete.go

@@ -39,7 +39,7 @@ var deleteCmd = &cobra.Command{
 
 		force, _ := cmd.Flags().GetBool("force")
 		var msg = "This action will delete a deployment's resource kind and its configuration history. Do you want to continue? [y/n]: "
-		if !force && !sdkcmdutil.ConfirmAction(msg, os.Stderr, os.Stdout) {
+		if !force && !sdkcmdutil.ConfirmAction(msg, os.Stdin, ecctl.Get().Config.OutputDevice) {
 			return nil
 		}
 

cmd/deployment/resource/restore.go

@@ -43,7 +43,7 @@ var restoreCmd = &cobra.Command{
 		var esKind = resKind == "elasticsearch"
 		var dataLoss = esKind && !restoreSnapshot
 		var msg = "This action restores an Elasticsearch resource without its snapshot which might incur data loss, do you want to continue? [y/n]: "
-		if dataLoss && !force && !sdkcmdutil.ConfirmAction(msg, os.Stderr, os.Stdout) {
+		if dataLoss && !force && !sdkcmdutil.ConfirmAction(msg, os.Stdin, ecctl.Get().Config.OutputDevice) {
 			return nil
 		}
 

cmd/deployment/resource/shutdown.go

@@ -42,7 +42,7 @@ var shutdownCmd = &cobra.Command{
 
 		force, _ := cmd.Flags().GetBool("force")
 		var msg = "This action will shut down a deployment's resource kind. Do you want to continue? [y/n]: "
-		if !force && !sdkcmdutil.ConfirmAction(msg, os.Stderr, os.Stdout) {
+		if !force && !sdkcmdutil.ConfirmAction(msg, os.Stdin, ecctl.Get().Config.OutputDevice) {
 			return nil
 		}
 

cmd/deployment/resource/start-maintenance.go

@@ -47,7 +47,7 @@ var startMaintCmd = &cobra.Command{
 		}
 
 		var msg = "This action will incur in downtime if used with the --all flag. Do you want to continue? [y/n]: "
-		if all && !force && !sdkcmdutil.ConfirmAction(msg, os.Stderr, os.Stdout) {
+		if all && !force && !sdkcmdutil.ConfirmAction(msg, os.Stdin, ecctl.Get().Config.OutputDevice) {
 			return nil
 		}
 

cmd/deployment/resource/stop.go

@@ -47,7 +47,7 @@ var stopCmd = &cobra.Command{
 		}
 
 		var msg = "This action will incur in downtime if used with the --all flag. Do you want to continue? [y/n]: "
-		if all && !force && !sdkcmdutil.ConfirmAction(msg, os.Stderr, os.Stdout) {
+		if all && !force && !sdkcmdutil.ConfirmAction(msg, os.Stdin, ecctl.Get().Config.OutputDevice) {
 			return nil
 		}
 

cmd/deployment/shutdown.go

@@ -35,7 +35,7 @@ var shutdownCmd = &cobra.Command{
 	RunE: func(cmd *cobra.Command, args []string) error {
 		force, _ := cmd.Flags().GetBool("force")
 		var msg = "This action will delete the specified deployment ID and its associated sub-resources, do you want to continue? [y/n]: "
-		if !force && !sdkcmdutil.ConfirmAction(msg, os.Stderr, os.Stdout) {
+		if !force && !sdkcmdutil.ConfirmAction(msg, os.Stdin, ecctl.Get().Config.OutputDevice) {
 			return nil
 		}
 

cmd/deployment/update.go

@@ -47,7 +47,7 @@ var updateCmd = &cobra.Command{
 
 		force, _ := cmd.Flags().GetBool("force")
 		var msg = `setting --prune-orphans to "true" will cause any resources not specified in the update request to be removed from the deployment, do you want to continue? [y/n]: `
-		if pruneOrphans && !force && !sdkcmdutil.ConfirmAction(msg, os.Stderr, os.Stdout) {
+		if pruneOrphans && !force && !sdkcmdutil.ConfirmAction(msg, os.Stdin, ecctl.Get().Config.OutputDevice) {
 			return nil
 		}
 

cmd/platform/allocator/vacate.go

@@ -99,7 +99,7 @@ var vacateAllocatorCmd = &cobra.Command{
 		overrideFailsafe, _ := cmd.Flags().GetBool("override-failsafe")
 		force, _ := cmd.Flags().GetBool("force")
 		var msg = "--override-failsafe has been flag specified. Are you sure you want to proceed? [y/N]: "
-		if overrideFailsafe && !force && !sdkcmdutil.ConfirmAction(msg, os.Stderr, os.Stdout) {
+		if overrideFailsafe && !force && !sdkcmdutil.ConfirmAction(msg, os.Stdin, ecctl.Get().Config.OutputDevice) {
 			return nil
 		}
 
@@ -132,7 +132,7 @@ var vacateAllocatorCmd = &cobra.Command{
 		}
 
 		skipTracking, _ := cmd.Flags().GetBool("skip-tracking")
-		if !force && skipTracking && !sdkcmdutil.ConfirmAction("--skip-tracking flag specified. Are you sure you want to proceed? [y/N]: ", os.Stdin, os.Stderr) {
+		if !force && skipTracking && !sdkcmdutil.ConfirmAction("--skip-tracking flag specified. Are you sure you want to proceed? [y/N]: ", os.Stdin, ecctl.Get().Config.OutputDevice) {
 			return nil
 		}