misc: Fix App Search typos (#259)

Author: acrewdson

cmd/deployment/create.go

@@ -179,10 +179,10 @@ func init() {
 	createCmd.Flags().Int32("apm-zones", 1, "Number of zones the APM instances will span")
 	createCmd.Flags().Int32("apm-size", 512, "Memory (RAM) in MB that each of the APM instances will have")
 
-	createCmd.Flags().Bool("appsearch", false, "Enables AppSearch for the deployment")
-	createCmd.Flags().String("appsearch-ref-id", "main-appsearch", "Optional RefId for the AppSearch deployment")
-	createCmd.Flags().Int32("appsearch-zones", 1, "Number of zones the AppSearch instances will span")
-	createCmd.Flags().Int32("appsearch-size", 2048, "Memory (RAM) in MB that each of the AppSearch instances will have")
+	createCmd.Flags().Bool("appsearch", false, "Enables App Search for the deployment")
+	createCmd.Flags().String("appsearch-ref-id", "main-appsearch", "Optional RefId for the App Search deployment")
+	createCmd.Flags().Int32("appsearch-zones", 1, "Number of zones the App Search instances will span")
+	createCmd.Flags().Int32("appsearch-size", 2048, "Memory (RAM) in MB that each of the App Search instances will have")
 
 	// The following flags will remain hidden until reads for deployment templates are available on ESS
 	createCmd.Flags().MarkHidden("deployment-template")

cmd/deployment/create_help.go

@@ -24,7 +24,7 @@ Sane default values are provided, making the command work out of the box even wh
 When version is not specified, the latest available stack version will automatically be used. 
 These are the available options:
 
-  * Simplified flags to set size and zone count for each instance type (Elasticsearch, Kibana, APM and AppSearch). 
+  * Simplified flags to set size and zone count for each instance type (Elasticsearch, Kibana, APM and App Search). 
   * Advanced flag for different Elasticsearch node types: --topology-element <json obj> (shorthand: -e).
     Note that the flag can be specified multiple times for complex topologies.
     The JSON object has the following format:
@@ -41,7 +41,7 @@ Save it, update or extend the topology and create a deployment using the saved p
 
 	// nolint
 	createExample = `## Create a deployment with the default values for Elasticsearch, a Kibana instance with a modified size, 
-and a default APM instance. While Elasticsearch and Kibana come enabled by default, both APM and AppSearch need to be 
+and a default APM instance. While Elasticsearch and Kibana come enabled by default, both APM and App Search need to be 
 enabled by using the "--apm" and "--appsearch" flags. The command will exit after the API response has been returned, without 
 waiting until the deployment resources have been created. 
 $ ecctl deployment create --name my-deployment --zones 2 --kibana-size 2048 --apm --apm-size 1024

pkg/deployment/depresource/appsearch.go

@@ -59,7 +59,7 @@ func NewAppSearch(params NewStateless) (*models.AppSearchPayload, error) {
 	}
 
 	if res.Payload.ClusterTemplate.Appsearch == nil {
-		return nil, fmt.Errorf("deployment: the %s template is not configured for AppSearch. Please use another template if you wish to start AppSearch instances",
+		return nil, fmt.Errorf("deployment: the %s template is not configured for App Search. Please use another template if you wish to start App Search instances",
 			params.TemplateID)
 	}
 

pkg/deployment/depresource/appsearch_test.go

@@ -159,7 +159,7 @@ func TestNewAppSearch(t *testing.T) {
 				),
 				Region: "ece-region",
 			}},
-			err: errors.New("deployment: the an ID template is not configured for AppSearch. Please use another template if you wish to start AppSearch instances"),
+			err: errors.New("deployment: the an ID template is not configured for App Search. Please use another template if you wish to start App Search instances"),
 		},
 		{
 			name: "succeeds with no argument override",

pkg/deployment/depresource/delete_stateless.go

@@ -46,7 +46,7 @@ func (params *DeleteStatelessParams) Validate() error {
 }
 
 // DeleteStateless deletes a stateless deployment resource like APM, Kibana
-// and AppSearch.
+// and App Search.
 func DeleteStateless(params DeleteStatelessParams) error {
 	if err := params.Validate(); err != nil {
 		return err

pkg/deployment/depresource/new_deployment_test.go

@@ -184,7 +184,7 @@ func TestNew(t *testing.T) {
 			wantErr: errors.New("deployment: the default template is not configured for APM. Please use another template if you wish to start APM instances"),
 		},
 		{
-			name: "Fails to create a deployment payload with ES, Kibana and Appsearch instances",
+			name: "Fails to create a deployment payload with ES, Kibana and App Search instances",
 			args: args{params: NewParams{
 				Version: "7.6.1",
 				Region:  "ece-region",
@@ -211,7 +211,7 @@ func TestNew(t *testing.T) {
 					mock.New200Response(mock.NewStructBody(apmKibanaTemplateResponse)),
 				),
 			}},
-			wantErr: errors.New("deployment: the default template is not configured for AppSearch. Please use another template if you wish to start AppSearch instances"),
+			wantErr: errors.New("deployment: the default template is not configured for App Search. Please use another template if you wish to start App Search instances"),
 		},
 		{
 			name: "Succeeds to create a deployment payload with ES and Kibana instances",

pkg/deployment/depresource/restore.go

@@ -33,7 +33,7 @@ type RestoreParams struct {
 }
 
 // Restore upgrades a stateless deployment resource like APM, Kibana
-// and AppSearch.
+// and App Search.
 func Restore(params RestoreParams) error {
 	if err := params.Validate(); err != nil {
 		return err

pkg/deployment/depresource/upgrade_stateless.go

@@ -26,7 +26,7 @@ import (
 )
 
 // UpgradeStateless upgrades a stateless deployment resource like APM, Kibana
-// and AppSearch.
+// and App Search.
 func UpgradeStateless(params deployment.ResourceParams) (*models.DeploymentResourceUpgradeResponse, error) {
 	if err := params.Validate(); err != nil {
 		return nil, err

pkg/platform/allocator/vacate_responses_test.go

@@ -57,7 +57,7 @@ type vacateCaseClusters struct {
 	kibana []vacateCaseClusterConfig
 	// APM clusters that will be simulated
 	apm []vacateCaseClusterConfig
-	// AppSearch clusters that will be simulated
+	// App Search clusters that will be simulated
 	appsearch []vacateCaseClusterConfig
 }
 

pkg/platform/allocator/vacate_test.go

@@ -626,7 +626,7 @@ func TestCheckVacateFailures(t *testing.T) {
 			}},
 		},
 		{
-			name: "Returns an error on AppSearch vacate failure",
+			name: "Returns an error on App Search vacate failure",
 			args: args{
 				failures: &models.MoveClustersDetails{
 					AppsearchClusters: []*models.MoveAppSearchDetails{
@@ -1227,7 +1227,7 @@ func Test_addAllocatorMovesToPool(t *testing.T) {
 			wantMoved:     true,
 		},
 		{
-			name: "Move clusters when no filter is specified (AppSearch)",
+			name: "Move clusters when no filter is specified (App Search)",
 			args: args{params: addAllocatorMovesToPoolParams{
 				ID: "allocator-1",
 				Pool: func() *pool.Pool {
@@ -1324,7 +1324,7 @@ func Test_addAllocatorMovesToPool(t *testing.T) {
 			wantMoved:     true,
 		},
 		{
-			name: "Move clusters when no filter is specified (AppSearch)",
+			name: "Move clusters when no filter is specified (App Search)",
 			args: args{params: addAllocatorMovesToPoolParams{
 				ID: "allocator-1",
 				Pool: func() *pool.Pool {