cmd: mark --type flag as required for plan cancel (#184)

Fixes an issue where a required flag had an "Optional" prefix in the description. 
I've also taken the opportunity to update the command to use the recommended CLI syntax

Author: karencfv

cmd/deployment/plan/cancel.go

@@ -29,7 +29,7 @@ import (
 
 // cancelPlan is the deployment subcommand
 var cancelPlan = &cobra.Command{
-	Use:     "cancel <deployment id> --type <type> --ref-id <ref-id>",
+	Use:     "cancel <deployment id> --type <type> [--ref-id <ref-id>]",
 	Short:   "Cancels a resource's pending plan",
 	PreRunE: sdkcmdutil.MinimumNArgsAndUUID(1),
 	RunE: func(cmd *cobra.Command, args []string) error {
@@ -53,7 +53,7 @@ var cancelPlan = &cobra.Command{
 
 func init() {
 	Command.AddCommand(cancelPlan)
-	cmdutil.AddTypeFlag(cancelPlan, "Optional", true)
+	cmdutil.AddTypeFlag(cancelPlan, "Required", true)
 	cancelPlan.MarkFlagRequired("type")
-	cancelPlan.Flags().String("ref-id", "", "Optional deployment type RefId, if not set, the RefId will be auto-discovered")
+	cancelPlan.Flags().String("ref-id", "", "Optional deployment RefId, if not set, the RefId will be auto-discovered")
 }

docs/ecctl_deployment_plan_cancel.md

@@ -7,15 +7,15 @@ Cancels a resource's pending plan
 Cancels a resource's pending plan
 
 ```
-ecctl deployment plan cancel <deployment id> --type <type> --ref-id <ref-id> [flags]
+ecctl deployment plan cancel <deployment id> --type <type> [--ref-id <ref-id>] [flags]
 ```
 
 ### Options
 
 ```
   -h, --help            help for cancel
-      --ref-id string   Optional deployment type RefId, if not set, the RefId will be auto-discovered
-      --type string     Optional deployment resource type (apm, appsearch, kibana, elasticsearch)
+      --ref-id string   Optional deployment RefId, if not set, the RefId will be auto-discovered
+      --type string     Required deployment resource type (apm, appsearch, kibana, elasticsearch)
 ```
 
 ### Options inherited from parent commands