Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue where wrong thread id was logged. #124

Merged
merged 2 commits into from
Feb 9, 2021
Merged

Fix issue where wrong thread id was logged. #124

merged 2 commits into from
Feb 9, 2021

Conversation

SebZal
Copy link
Contributor

@SebZal SebZal commented Dec 15, 2020

Fix for #123

@apmmachine
Copy link
Contributor

apmmachine commented Dec 15, 2020 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #124 updated

  • Start Time: 2021-02-09T06:33:32.052+0000

  • Duration: 11 min 49 sec

  • Commit: de5dfd3

Test stats 🧪

Test Results
Failed 0
Passed 68
Skipped 6
Total 74

Trends 🧪

Image of Build Times

Image of Tests

snakefoot
snakefoot approved these changes Dec 15, 2020
View reviewed changes
Copy link
Contributor

@snakefoot snakefoot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@sgryphon
Copy link
Contributor

Fix looks good to me 👍

russcam
russcam approved these changes Feb 9, 2021
View reviewed changes
Copy link
Contributor

@russcam russcam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @SebZal 👍

@russcam russcam merged commit 100934a into elastic:master Feb 9, 2021
@russcam russcam added bug Something isn't working v1.5.3 labels Jun 1, 2021
russcam added a commit that referenced this pull request Jun 1, 2021
@SebZal @russcam
Fix issue where wrong thread id was logged. (#124)
a944863 
Co-authored-by: Russ Cam <russ.cam@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snakefoot snakefoot snakefoot approved these changes

@russcam russcam russcam approved these changes

Assignees
No one assigned
Labels
bug Something isn't working v1.5.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@SebZal @apmmachine @sgryphon @russcam @snakefoot