Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Add container metric fields - Stage 1 #1529

Merged
merged 8 commits into from
Jul 29, 2021

Conversation

kaiyan-sheng
Copy link
Contributor

We are working on defining a set of fields for container inventory schema and during this process, we see some metrics that are currently not included in the container ECS fields. This RFC is to add these container metric fields into ECS so all users can leverage these fields when monitoring container performance such as CPU, memory, disk IO, and network.

Copy link
Member

@jsoriano jsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks! 👍

rfcs/text/0025-container-metric-fields.md Outdated Show resolved Hide resolved
rfcs/text/0025-container-metric-fields.md Show resolved Hide resolved
rfcs/text/0025-container-metric-fields.md Outdated Show resolved Hide resolved
rfcs/text/0025-container-metric-fields.md Outdated Show resolved Hide resolved
rfcs/text/0025-container-metric-fields.md Show resolved Hide resolved
Copy link
Member

@ebeahan ebeahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Can @cyrille-leclerc also review as the sponsor?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants