-
Notifications
You must be signed in to change notification settings - Fork 417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS] Add Kibana tutorial to ECS mapping docs #1772
[DOCS] Add Kibana tutorial to ECS mapping docs #1772
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
The only thing I am uncertain about, but I think @jamiehynds can answer: do we want to keep mention of 'ECS Mapper'?
If you prefer to use Beats or Logstash pipelines, you can also use the ECS Mapper to turn a CSV version of the spreadsheet into an equivalent Beats or Logstash pipeline.
Thanks! It's worth noting that the spreadsheet template also mentions ECS Mapper: It's outside the scope of this PR, but we probably want to update or remove that sheet. |
docs/migrating/converting.asciidoc
Outdated
After exporting your mapping spreadsheet to CSV, ECS Mapper will convert your field mapping | ||
to equivalent pipelines for Beats, Elasticsearch, and Logstash. Learn more at | ||
https://github.com/elastic/ecs-mapper[ECS Mapper]. | ||
If you prefer to use {beats} or {ls} pipelines, you can also use the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kgeller @jamiehynds - I'm in favor of archiving ecs-mapper
and indicating it's no longer maintained in the project's README. Unfortunately, the ECS team doesn't have the spare capacity to maintain or improve it right now.
If we archive the project, we can remove this reference from the docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pushed bfaff54 to remove the reference. That lets us decouple these docs from the archival of the ecs-mapper
repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
With the reference removed, does that address your question in #1772 (review) @kgeller?
Yes, it does! |
Thanks for the reviews! |
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
elastic/kibana#101216 adds a new ECS mapper feature to Kibana's Ingest Pipelines UI. This updates the ECS docs to cover the new feature. (cherry picked from commit c3734cc)
elastic/kibana#101216 adds a new ECS mapper feature to Kibana's Ingest Pipelines UI. This updates the ECS docs to cover the new feature. (cherry picked from commit c3734cc)
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
elastic/kibana#101216 adds a new ECS mapper feature to Kibana's Ingest Pipelines UI. This updates the ECS docs to cover the new feature. (cherry picked from commit c3734cc) Co-authored-by: James Rodewig <james.rodewig@elastic.co>
elastic/kibana#101216 adds a new ECS mapper feature to Kibana's Ingest Pipelines UI. This updates the ECS docs to cover the new feature.
Preview
https://ecs_1772.docs-preview.app.elstc.co/guide/en/ecs/master/ecs-converting.html#ecs-map-custom-data-to-ecs-es-pipeline