[RFC] added new field: threat.indicator.id - resolves GH-2252 #2307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brett-fitz
changed the title
|
@ebeahan This should be good to go and ready for discussion. Let me know if there are any issues with the PR! 😄 |
|
This PR is stale because it has been open for 60 days with no activity. |
|
Looks ok to me but I would like to have another approval from ecs maintainers / security folks |
|
@mjwolf could you check it as well? |
mjwolf
reviewed
Mar 18, 2024
There was a problem hiding this comment.
Hi @brett-fitz, I just have a few minor suggestions, otherwise LGTM
|
@trisch-me @mjwolf My organization has dissolved and formed into a new entity. I'm going to resubmit this PR under a branch off my personal fork with the requested changes from above. |
|
Closing this PR. Now please refer to the new one: #2324 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
threat.indicator.idfield. Resolves #2252.The new field
threat.indicator.idwill allow for security systems to append a threat.indicator.id. This field can have multiple values to allow for the identification of the same indicator across systems that use different ID formats.Common serialization format you may expect to see here is a STIX 2.x indicator id. Here is an example of one being produced.
{ "type": "indicator", "spec_version": "2.1", "id": "indicator--8a8c60c4-00a8-43dd-ad76-8004ee718c39", "created": "2023-12-21T17:55:29.187214Z", "modified": "2023-12-21T17:55:29.187214Z", "name": "Malicious activity", "description": "Indicator for a known malicious IP address", "pattern": "[ipv4-addr:value = '192.168.1.1']", "pattern_type": "stix", "pattern_version": "2.1", "valid_from": "2023-01-01T12:00:00Z" }