Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ECS tooling rewrite brought about by the need to reuse field sets as a different name #864

Merged
merged 113 commits into from
Jun 11, 2020

Commits on Apr 16, 2020

  1. Function to turn single word reuse locations into the dictionary nota…

    …tion
    Mathieu Martin committed Apr 16, 2020
    Configuration menu
    Copy the full SHA
    6568fe2 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e0befee View commit details
    Browse the repository at this point in the history
  3. Actually resolve the shorthands when reading schemas

    Mathieu Martin committed Apr 16, 2020
    Configuration menu
    Copy the full SHA
    53556a0 View commit details
    Browse the repository at this point in the history
  4. Unrelated: removed dead code

    Mathieu Martin committed Apr 16, 2020
    Configuration menu
    Copy the full SHA
    88313e7 View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2020

  1. Precompute the full path of a nesting, considering nesting as another…

    … name
    Mathieu Martin committed Apr 17, 2020
    Configuration menu
    Copy the full SHA
    05d2847 View commit details
    Browse the repository at this point in the history
  2. First pass at self-nesting

    Mathieu Martin committed Apr 17, 2020
    Configuration menu
    Copy the full SHA
    ee51313 View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2020

  1. Missed a generated file

    Mathieu Martin committed Apr 20, 2020
    Configuration menu
    Copy the full SHA
    108dd35 View commit details
    Browse the repository at this point in the history
  2. Code formatting

    Mathieu Martin committed Apr 20, 2020
    Configuration menu
    Copy the full SHA
    ab82e6e View commit details
    Browse the repository at this point in the history
  3. Changelog

    Mathieu Martin committed Apr 20, 2020
    Configuration menu
    Copy the full SHA
    a3b5fde View commit details
    Browse the repository at this point in the history
  4. Fix asciidoc link when nesting as another name

    Mathieu Martin committed Apr 20, 2020
    Configuration menu
    Copy the full SHA
    2918cdd View commit details
    Browse the repository at this point in the history
  5. Change the wording of using a field set at the root of events (instea…

    …d of 'top level').
    Mathieu Martin committed Apr 20, 2020
    Configuration menu
    Copy the full SHA
    d0c0271 View commit details
    Browse the repository at this point in the history
  6. Remove commented code

    Mathieu Martin committed Apr 20, 2020
    Configuration menu
    Copy the full SHA
    c90885f View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2020

  1. WIP

    Mathieu Martin committed Apr 22, 2020
    Configuration menu
    Copy the full SHA
    df9843d View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2020

  1. Start massive refactor of schema_reader...

    Bunch of stuff moving to new script schema_processor.py
    Mathieu Martin committed Apr 29, 2020
    Configuration menu
    Copy the full SHA
    503f90b View commit details
    Browse the repository at this point in the history
  2. Make the 'reusable' field set properties explicit

    Mathieu Martin committed Apr 29, 2020
    Configuration menu
    Copy the full SHA
    abee212 View commit details
    Browse the repository at this point in the history
  3. Move a bunch of code to schema_processor.py

    Mathieu Martin committed Apr 29, 2020
    Configuration menu
    Copy the full SHA
    e11fe38 View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2020

  1. Give schemas/README.md some much needed attention

    Mathieu Martin committed Apr 30, 2020
    Configuration menu
    Copy the full SHA
    4b2039c View commit details
    Browse the repository at this point in the history

Commits on May 6, 2020

  1. new schema loader WIP

    Mathieu Martin committed May 6, 2020
    Configuration menu
    Copy the full SHA
    819575c View commit details
    Browse the repository at this point in the history

Commits on May 7, 2020

  1. About to turn the schema loader into a shotgun...

    Anything can be merged over other fields. Here's not the place to enforce
    good ECS citizenry.
    Mathieu Martin committed May 7, 2020
    Configuration menu
    Copy the full SHA
    0af1aa3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4725167 View commit details
    Browse the repository at this point in the history
  3. Import the changes from PR elastic#821

    Mathieu Martin committed May 7, 2020
    Configuration menu
    Copy the full SHA
    d16c361 View commit details
    Browse the repository at this point in the history
  4. Move nesting structure comment to top of file

    Mathieu Martin committed May 7, 2020
    Configuration menu
    Copy the full SHA
    5b27a8b View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    50a49a3 View commit details
    Browse the repository at this point in the history

Commits on May 8, 2020

  1. Start future schema cleaner w/ basic visitor function to navigate the…

    … nested tree
    Mathieu Martin committed May 8, 2020
    Configuration menu
    Copy the full SHA
    a1c20d6 View commit details
    Browse the repository at this point in the history
  2. Raise clear error on missing schema name

    Mathieu Martin committed May 8, 2020
    Configuration menu
    Copy the full SHA
    94ce10b View commit details
    Browse the repository at this point in the history
  3. Add 'mock' testing dependency

    Mathieu Martin committed May 8, 2020
    Configuration menu
    Copy the full SHA
    5344341 View commit details
    Browse the repository at this point in the history
  4. Make 'title' a schema_detail as well

    Mathieu Martin committed May 8, 2020
    Configuration menu
    Copy the full SHA
    3fe758b View commit details
    Browse the repository at this point in the history
  5. Keep improving schema/readme

    Mathieu Martin committed May 8, 2020
    Configuration menu
    Copy the full SHA
    e28c737 View commit details
    Browse the repository at this point in the history
  6. Create a helper for list subtraction...

    My brain can't deal with Python list comprehensions
    Mathieu Martin committed May 8, 2020
    Configuration menu
    Copy the full SHA
    9bb6722 View commit details
    Browse the repository at this point in the history
  7. schema level cleanups looking pretty good

    Mathieu Martin committed May 8, 2020
    Configuration menu
    Copy the full SHA
    6202462 View commit details
    Browse the repository at this point in the history

Commits on May 11, 2020

  1. Configuration menu
    Copy the full SHA
    ff17836 View commit details
    Browse the repository at this point in the history

Commits on May 12, 2020

  1. Raise on multiline short descriptions

    Mathieu Martin committed May 12, 2020
    Configuration menu
    Copy the full SHA
    0ab1b1c View commit details
    Browse the repository at this point in the history
  2. Fill in field name for intermediary fields as well

    Mathieu Martin committed May 12, 2020
    Configuration menu
    Copy the full SHA
    7f7511d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    c693b62 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    ee6819b View commit details
    Browse the repository at this point in the history
  5. First checks for fields

    Mathieu Martin committed May 12, 2020
    Configuration menu
    Copy the full SHA
    2610d14 View commit details
    Browse the repository at this point in the history
  6. Implement the simple defaults for fields

    Mathieu Martin committed May 12, 2020
    Configuration menu
    Copy the full SHA
    c607ab0 View commit details
    Browse the repository at this point in the history
  7. better multi-fields datatype support than before

    Mathieu Martin committed May 12, 2020
    Configuration menu
    Copy the full SHA
    1ec38d1 View commit details
    Browse the repository at this point in the history

Commits on May 13, 2020

  1. Precalculate the 'path' to a field as we build the deeply nested stru…

    …cture
    Mathieu Martin committed May 13, 2020
    Configuration menu
    Copy the full SHA
    a6140a1 View commit details
    Browse the repository at this point in the history
  2. Implement flat/dashed names for all fields. Close to feature parity w…

    …ith schema_reader
    Mathieu Martin committed May 13, 2020
    Configuration menu
    Copy the full SHA
    24bb145 View commit details
    Browse the repository at this point in the history

Commits on May 15, 2020

  1. Add intermediary=True to fields implicitly created to contain others.

    They shouldn't be held to the same standards of completeness (e.g. presence of a description) as the other fields.
    Mathieu Martin committed May 15, 2020
    Configuration menu
    Copy the full SHA
    6a0bc77 View commit details
    Browse the repository at this point in the history
  2. Correct my engrish. intermediary => intermediate

    Mathieu Martin committed May 15, 2020
    Configuration menu
    Copy the full SHA
    9d19424 View commit details
    Browse the repository at this point in the history
  3. Precalculate the leaf field name

    Mathieu Martin committed May 15, 2020
    Configuration menu
    Copy the full SHA
    fcab216 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    ff718ca View commit details
    Browse the repository at this point in the history
  5. Comment out all the 'path' stuff. Must be calculated later

    Mathieu Martin committed May 15, 2020
    Configuration menu
    Copy the full SHA
    f3ab162 View commit details
    Browse the repository at this point in the history
  6. Tentative final state for cleaner.py, much simplified

    Mathieu Martin committed May 15, 2020
    Configuration menu
    Copy the full SHA
    14850a5 View commit details
    Browse the repository at this point in the history
  7. Comments at the top

    Mathieu Martin committed May 15, 2020
    Configuration menu
    Copy the full SHA
    b7e1adb View commit details
    Browse the repository at this point in the history

Commits on May 18, 2020

  1. Configuration menu
    Copy the full SHA
    2d41e9b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    685d7a0 View commit details
    Browse the repository at this point in the history

Commits on May 25, 2020

  1. Add another test for the already normalized self reuse

    Mathieu Martin committed May 25, 2020
    Configuration menu
    Copy the full SHA
    490a822 View commit details
    Browse the repository at this point in the history
  2. Why does this throw my brain for a loop

    Mathieu Martin committed May 25, 2020
    Configuration menu
    Copy the full SHA
    caee0ee View commit details
    Browse the repository at this point in the history

Commits on May 26, 2020

  1. Both foreign reuse and self-reuse work now :-D

    Mathieu Martin committed May 26, 2020
    Configuration menu
    Copy the full SHA
    45e5384 View commit details
    Browse the repository at this point in the history
  2. Move visitor to its own module

    Mathieu Martin committed May 26, 2020
    Configuration menu
    Copy the full SHA
    88090fd View commit details
    Browse the repository at this point in the history
  3. First reasonable stab at finalizing the fields.

    Mathieu Martin committed May 26, 2020
    Configuration menu
    Copy the full SHA
    a8a451d View commit details
    Browse the repository at this point in the history

Commits on May 27, 2020

  1. New way to capture what's 'nested_here', make process.parent a reuse …

    …tests
    Mathieu Martin committed May 27, 2020
    Configuration menu
    Copy the full SHA
    6051d52 View commit details
    Browse the repository at this point in the history
  2. Start capturing original_fieldset for reused fields as well, streamli…

    …ne tests
    Mathieu Martin committed May 27, 2020
    Configuration menu
    Copy the full SHA
    3bbc26f View commit details
    Browse the repository at this point in the history
  3. Clean the allowed values as well

    Mathieu Martin committed May 27, 2020
    Configuration menu
    Copy the full SHA
    c095081 View commit details
    Browse the repository at this point in the history
  4. Fix problem with original_fieldset and write test for calculate_final…

    …_values
    Mathieu Martin committed May 27, 2020
    Configuration menu
    Copy the full SHA
    fe30e02 View commit details
    Browse the repository at this point in the history
  5. Function docstrings in finalizer.py

    Mathieu Martin committed May 27, 2020
    Configuration menu
    Copy the full SHA
    0263d56 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    fccaa6c View commit details
    Browse the repository at this point in the history

Commits on May 28, 2020

  1. Reasonable implementation of filtering subsets

    Mathieu Martin committed May 28, 2020
    Configuration menu
    Copy the full SHA
    903b0bd View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ca82b70 View commit details
    Browse the repository at this point in the history
  3. Calculate flat_name for multi_fields

    Mathieu Martin committed May 28, 2020
    Configuration menu
    Copy the full SHA
    ce65c69 View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2020

  1. Move helper func is_intermediate(field) to the helpers

    Mathieu Martin committed Jun 1, 2020
    Configuration menu
    Copy the full SHA
    0f91bc4 View commit details
    Browse the repository at this point in the history
  2. WIP new generator using all the new schema scripts

    Mathieu Martin committed Jun 1, 2020
    Configuration menu
    Copy the full SHA
    1326f43 View commit details
    Browse the repository at this point in the history
  3. WIP on intermediate_files.py generator for ECS YAML files

    Mathieu Martin committed Jun 1, 2020
    Configuration menu
    Copy the full SHA
    8e836ca View commit details
    Browse the repository at this point in the history
  4. Initial stab at fixing an issue around chained nestings: original_fie…

    …ldset is incorrect
    Mathieu Martin committed Jun 1, 2020
    Configuration menu
    Copy the full SHA
    d9acd1c View commit details
    Browse the repository at this point in the history
  5. Remove old debugging code, replace with comment as a hint

    Mathieu Martin committed Jun 1, 2020
    Configuration menu
    Copy the full SHA
    388204c View commit details
    Browse the repository at this point in the history
  6. Fix bug where explicit legit object fields were incorrectly flagged a…

    …s intermediate fields
    Mathieu Martin committed Jun 1, 2020
    Configuration menu
    Copy the full SHA
    fa19654 View commit details
    Browse the repository at this point in the history

Commits on Jun 2, 2020

  1. Don't publish the deeply nested ecs.yml for now

    Mathieu Martin committed Jun 2, 2020
    Configuration menu
    Copy the full SHA
    42ea8f7 View commit details
    Browse the repository at this point in the history
  2. Remove old versions of the code

    Mathieu Martin committed Jun 2, 2020
    Configuration menu
    Copy the full SHA
    f3f44ab View commit details
    Browse the repository at this point in the history
  3. Introduce new optional attribute about reuse, for order of performing…

    … reuses
    Mathieu Martin committed Jun 2, 2020
    Configuration menu
    Copy the full SHA
    f32e56f View commit details
    Browse the repository at this point in the history
  4. Perform reuse in prescribed order. Temp copy by reference no longer n…

    …ecessary.
    Mathieu Martin committed Jun 2, 2020
    Configuration menu
    Copy the full SHA
    e13a05e View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2020

  1. Rewrite intermediate files generator using visitor pattern

    Mathieu Martin committed Jun 3, 2020
    Configuration menu
    Copy the full SHA
    d9b6b49 View commit details
    Browse the repository at this point in the history
  2. Comment out a bunch of things for initial PR review...

    These are improvements we'll want to have, but they'll come as a separate PR.
    Mathieu Martin committed Jun 3, 2020
    Configuration menu
    Copy the full SHA
    c17c46d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    342cc98 View commit details
    Browse the repository at this point in the history
  4. All generated files except asciidocs, as of latest changes

    Mathieu Martin committed Jun 3, 2020
    Configuration menu
    Copy the full SHA
    d0d89c4 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    d716c3a View commit details
    Browse the repository at this point in the history
  6. introduce the new attribute 'reused_here' immediately, after all...

    It removes one reason why we had to pass the deeply nested field structure to asciidoc in the first place.
    Mathieu Martin committed Jun 3, 2020
    Configuration menu
    Copy the full SHA
    ffd71f5 View commit details
    Browse the repository at this point in the history
  7. Append short description to 'reused_here'

    Mathieu Martin committed Jun 3, 2020
    Configuration menu
    Copy the full SHA
    eb83c25 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    321cc5f View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    4ca8fe1 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    81e626c View commit details
    Browse the repository at this point in the history
  11. asciidoc as of now. one major problem left

    Mathieu Martin committed Jun 3, 2020
    Configuration menu
    Copy the full SHA
    caa0eb5 View commit details
    Browse the repository at this point in the history
  12. Fix subtle bug where self-nestings would incorrectly mark parent fiel…

    …dset as reused
    Mathieu Martin committed Jun 3, 2020
    Configuration menu
    Copy the full SHA
    f506a73 View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2020

  1. Remove subset tests that have been replaced...

    Update new tests to capture one more edge case that was tested in the deleted test.
    Mathieu Martin committed Jun 4, 2020
    Configuration menu
    Copy the full SHA
    86848b2 View commit details
    Browse the repository at this point in the history
  2. Use new scripts to load ECS fields in test_ecs_spec.py

    Mathieu Martin committed Jun 4, 2020
    Configuration menu
    Copy the full SHA
    8b3d52d View commit details
    Browse the repository at this point in the history
  3. Code formatting

    Mathieu Martin committed Jun 4, 2020
    Configuration menu
    Copy the full SHA
    dc71e03 View commit details
    Browse the repository at this point in the history
  4. Make test output verbose

    Mathieu Martin committed Jun 4, 2020
    Configuration menu
    Copy the full SHA
    b33f8d3 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    e5140b9 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    1496d83 View commit details
    Browse the repository at this point in the history
  7. Also re-nest hash at process.parent

    Mathieu Martin committed Jun 4, 2020
    Configuration menu
    Copy the full SHA
    73ad62a View commit details
    Browse the repository at this point in the history
  8. Undo a wording improvement to simplify rewrite PR review

    Mathieu Martin committed Jun 4, 2020
    Configuration menu
    Copy the full SHA
    face9d4 View commit details
    Browse the repository at this point in the history
  9. Temporarily re-add object_type for initial review

    Mathieu Martin committed Jun 4, 2020
    Configuration menu
    Copy the full SHA
    fac6109 View commit details
    Browse the repository at this point in the history
  10. Merge branch 'master' into nest-as-rampage

    Trivial conflict in changelog.
    
    Interesting conflict with elastic#851. The new scripts/schema/loader.py file
    has most of the new code around loading ECS files from git refs. In this
    merge commit I'm also slightly adjusting comments and wording of output
    messages around this.
    Mathieu Martin committed Jun 4, 2020
    Configuration menu
    Copy the full SHA
    0fac563 View commit details
    Browse the repository at this point in the history
  11. Remove old PR ID from relevant changelog entries. This will be a clea…

    …n new PR.
    Mathieu Martin committed Jun 4, 2020
    Configuration menu
    Copy the full SHA
    b812cf7 View commit details
    Browse the repository at this point in the history
  12. Code comment formatting

    Mathieu Martin committed Jun 4, 2020
    Configuration menu
    Copy the full SHA
    14c95e4 View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2020

  1. Update an outdated docstring

    Mathieu Martin committed Jun 8, 2020
    Configuration menu
    Copy the full SHA
    bf16551 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    96c06bb View commit details
    Browse the repository at this point in the history
  3. Improve an unrelated test

    Mathieu Martin committed Jun 8, 2020
    Configuration menu
    Copy the full SHA
    78a3d6d View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2020

  1. Remove commented out code

    Mathieu Martin committed Jun 9, 2020
    Configuration menu
    Copy the full SHA
    1e63726 View commit details
    Browse the repository at this point in the history
  2. Finish the comment for subset_filter.py

    Mathieu Martin committed Jun 9, 2020
    Configuration menu
    Copy the full SHA
    530691a View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    0fa6fe1 View commit details
    Browse the repository at this point in the history
  4. Fix load_yaml_file bug

    Mathieu Martin committed Jun 9, 2020
    Configuration menu
    Copy the full SHA
    035449e View commit details
    Browse the repository at this point in the history
  5. Pin the version of mock

    Mathieu Martin committed Jun 9, 2020
    Configuration menu
    Copy the full SHA
    0353f75 View commit details
    Browse the repository at this point in the history
  6. Fix merge_fields bug

    Mathieu Martin committed Jun 9, 2020
    Configuration menu
    Copy the full SHA
    91e4660 View commit details
    Browse the repository at this point in the history
  7. Fix issue with tracing fields getting mangled

    Mathieu Martin committed Jun 9, 2020
    Configuration menu
    Copy the full SHA
    98745ca View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    866f1b9 View commit details
    Browse the repository at this point in the history
  9. Changelog

    Mathieu Martin committed Jun 9, 2020
    Configuration menu
    Copy the full SHA
    34595a3 View commit details
    Browse the repository at this point in the history
  10. Space. The final frontier.

    Mathieu Martin committed Jun 9, 2020
    Configuration menu
    Copy the full SHA
    97613cf View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    c841c53 View commit details
    Browse the repository at this point in the history
  12. Fix spacing

    Mathieu Martin committed Jun 9, 2020
    Configuration menu
    Copy the full SHA
    d6ec0ac View commit details
    Browse the repository at this point in the history
  13. Marshall was right, these two functions were the same. Deleted one of…

    … them.
    Mathieu Martin committed Jun 9, 2020
    Configuration menu
    Copy the full SHA
    91e7f16 View commit details
    Browse the repository at this point in the history