-
Notifications
You must be signed in to change notification settings - Fork 418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define process.parent via the new field reuse mechanism #868
Conversation
@rw-access When introducing PE, we had discussed that it belonged both under |
Awesome. Before I ✔️, this adds |
@rw-access Yes, both With the revamped reuse mechanism, we no longer use to define reuse at |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢
Also, I noticed this typo for process.args description: >
Array of process arguments, starting with the absolute path to the executable. For the first arg, I think it should be passed-through as is, so I think we can remove that note so that it's just this: description: >
Array of process arguments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Looks not so good to use |
The
process.parent
fields had initially been defined by duplicating each field explicitly, since the field reuse mechanism didn't support field reuse within the same field set at the time.Introducing
process.parent.*
by duplicating fields has predictably led to a few small mistakes, despite us squinting very hard and trying to avoid this :-)process.parent
twin.pe
was only reused underprocess
, but notprocess.parent
. This was not intentional.This PR removes the field duplication by using the improved reuse mechanism. This means both problems described above are also resolved by this PR.