-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improves the options and instructions for install #405
Conversation
@sethmlarson I'm not sure about these test failures. They don't seem to be related to this change 🤔 |
@joshdevins Definitely unrelated. You can ignore those, we'll need to update our Elasticsearch config for 8.0. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! A handful of comments for you:
Eland's dependencies (and transitive dependencies) require quite a few prerequisites like numpy, libzip, libjpeg, etc. On a normal macOS machine this isn't so bad and things tend to "just work", however on vanilla Debian machines such as the default Debian 10 image on GCP, there are quite a few prerequisites to work through. This change introduces instructions that explicitly help with Debian installations, and a second option to build a Debian Docker container in order to avoid having to figure out the dependencies needed for your particular distribution. The Docker container version is really only useful when you want to just run the installed scripts but it provides a very easy mechanism if people just want to, for example, upload PyTorch NLP models and don't actually want to use any of the other eland functionality.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Eland's dependencies (and transitive dependencies) require quite a few
prerequisites like numpy, libzip, libjpeg, etc. On a normal macOS
machine this isn't so bad and things tend to "just work", however on
vanilla Debian machines such as the default Debian 10 image on GCP,
there are quite a few prerequisites to work through.
This change introduces instructions that explicitly help with Debian
installations, and a second option to build a Debian Docker container in
order to avoid having to figure out the dependencies needed for your
particular distribution.
The Docker container version is really only useful when you want to just
run the installed scripts but it provides a very easy mechanism if
people just want to, for example, upload PyTorch NLP models and don't
actually want to use any of the other eland functionality.