Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve 'mage checkNoChanges' error message #144

Merged
merged 1 commit into from
Aug 21, 2023

Conversation

AndersonQ
Copy link
Member

What does this PR do?

Improves the 'mage checkNoChanges' error message making it better explain what might be causing the error and the possible solitions.

Why is it important?

The current error message states running mage update will fix the problems, however it isn't always true.

Checklist

  • My code follows the style guidelines of this project
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] I have added an entry in CHANGELOG.md

Related issues

  • N/A

@AndersonQ AndersonQ added the enhancement New feature or request label Aug 21, 2023
@AndersonQ AndersonQ requested a review from a team as a code owner August 21, 2023 09:09
@AndersonQ AndersonQ self-assigned this Aug 21, 2023
@AndersonQ AndersonQ requested review from belimawr and fearful-symmetry and removed request for a team August 21, 2023 09:09
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

cc @AndersonQ

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-08-21T09:10:13.170+0000

  • Duration: 11 min 48 sec

Test stats 🧪

Test Results
Failed 0
Passed 791
Skipped 25
Total 816

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@AndersonQ AndersonQ merged commit 2e67042 into elastic:main Aug 21, 2023
5 checks passed
@AndersonQ AndersonQ deleted the improve-error-msg branch August 21, 2023 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants