Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make hostmetricsreceiver available in Agent running in OTel mode #4706

Closed

Conversation

ycombinator
Copy link
Contributor

@ycombinator ycombinator commented May 8, 2024

What does this PR do?

This PR makes the hostmetrics receiver available to users running Elastic Agent in otel mode.

Why is it important?

To allow users of Elastic Agent running as as OpenTelemetry Collector to configure pipelines containing the hostmetricsreceiver.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

@ycombinator ycombinator requested a review from a team as a code owner May 8, 2024 14:11
@ycombinator ycombinator requested review from blakerouse, andrzej-stencel and michalpristas and removed request for blakerouse May 8, 2024 14:11
Copy link
Contributor

mergify bot commented May 8, 2024

This pull request does not have a backport label. Could you fix it @ycombinator? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 8./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip label May 8, 2024
@ycombinator ycombinator added Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team backport-v8.14.0 Automated backport with mergify labels May 8, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

@ycombinator ycombinator requested review from pchila and removed request for michalpristas May 8, 2024 14:17
@mergify mergify bot removed the backport-skip label May 8, 2024
@ycombinator
Copy link
Contributor Author

Serverless tests are failing in CI with the following error:

>>> (windows-amd64-2022-fleet) Test output (sudo) (stdout): Error: error starting service: failed to start service (Elastic Agent): The service did not respond to the start or control request in a timely fashion.

Copy link
Contributor

mergify bot commented May 8, 2024

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b otel-mode-add-hostmetrics-receiver upstream/otel-mode-add-hostmetrics-receiver
git merge upstream/main
git push upstream otel-mode-add-hostmetrics-receiver

@ycombinator ycombinator force-pushed the otel-mode-add-hostmetrics-receiver branch from 5052240 to a03b773 Compare May 8, 2024 16:53
@ycombinator
Copy link
Contributor Author

ycombinator commented May 9, 2024

@strawgate This PR — and therefore the hostmetricsreceiver is not going to make it into 8.14 given that the final BC is being cut tomorrow and there are still CI errors that need investigating.

We did get the elasticsearchexporter and filterprocessor into 8.14 though. Will keep working on getting hostmetricsreceiver and resourcedetectionprocessor into the next release.

@ycombinator ycombinator closed this May 9, 2024
@ycombinator ycombinator deleted the otel-mode-add-hostmetrics-receiver branch May 9, 2024 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v8.14.0 Automated backport with mergify Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants