-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow agent to monitor endpoint #4789
Allow agent to monitor endpoint #4789
Conversation
This pull request does not have a backport label. Could you fix it @fearful-symmetry? 🙏
NOTE: |
So, |
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
CI may be various kinds of broken until the snapshot beats build are updated, taking out of draft since technically everything needed is merged. |
Still tinkering with the tests... |
So, I ended up adding a decent bit of logic to the integration test, hopefully to better shake out any problems that might exist with the metric update logic. HOWEVER, I'm waiting for the EDIT: tests are done, and working. |
internal/pkg/agent/application/coordinator/coordinator_state.go
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this looks good.
I would really like to see checkinpid
to just be pid
, but not a blocker.
internal/pkg/agent/application/coordinator/coordinator_state.go
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions on atomic handling, otherwise looks good
internal/pkg/agent/application/coordinator/coordinator_state.go
Outdated
Show resolved
Hide resolved
This pull request is now in conflicts. Could you fix it? 🙏
|
Quality Gate passedIssues Measures |
What does this PR do?
closes #4083
This is a large and fairly wide-ranging set of changes that allows agent to monitor and report usage metrics for endpoint.
Specifically:
system/process
metricset to monitor endpointlocal
env var in mage, solocal=agentbeat
will only build agentbeat, then pull other binaries from upstream. Needed this for testing, but kept it because it seemed vaguely useful. However, we don't need to merge it.Checklist
./changelog/fragments
using the changelog tool