[8.14](backport #4727) Make delayed enrollment try indefinitely #4800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
* Make delay enrollment indefinite. * Add changelog entry. (cherry picked from commit c14df02)
mergify
bot
requested review from
AndersonQ and
pchila
and removed request for
a team
|
|
|
This pull request has not been merged yet. Could you please review and merge it @blakerouse? 🙏 |
2 similar comments
|
This pull request has not been merged yet. Could you please review and merge it @blakerouse? 🙏 |
|
This pull request has not been merged yet. Could you please review and merge it @blakerouse? 🙏 |
|
@blakerouse we will miss the 8.14.1 version unless we are merging this today. |
|
Very confident, this should be merged. |
jlind23
approved these changes
Jun 10, 2024
|
blakerouse
approved these changes
Jun 10, 2024
This was referenced Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Make delayed enrollment try indefinitely to enroll into Fleet.
Why is it important?
In some cases when a new machine comes online with delayed enrollment it doesn't have network access immediately so the enrollment needs to keep trying until it is able to successfully enroll into Fleet.
Checklist
[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files[ ] I have added tests that prove my fix is effective or that my feature works./changelog/fragmentsusing the changelog toolDisruptive User Impact
Doesn't disrupt the user, it provides the more reliability for delayed enrollment.
How to test this PR locally
--delay-enrollRelated issues
This is an automatic backport of pull request #4727 done by [Mergify](https://mergify.com).