Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded Infof line in runtime #4986

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

fearful-symmetry
Copy link
Contributor

@fearful-symmetry fearful-symmetry commented Jun 21, 2024

What does this PR do?

closes #4974

Once again forgot to remove one of me debug lines before I merged something. This removes a superfluous Infof() call.

Copy link
Contributor

mergify bot commented Jun 21, 2024

This pull request does not have a backport label. Could you fix it @fearful-symmetry? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 8./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@pierrehilbert pierrehilbert added the Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team label Jun 22, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

@pierrehilbert
Copy link
Contributor

@fearful-symmetry What can we do to avoid this from happening again?
Be more attentive during the reviewing phase?
Using debug level instead of info level to limit the risk?

@fearful-symmetry fearful-symmetry merged commit c79c509 into elastic:main Jun 24, 2024
16 checks passed
@fearful-symmetry
Copy link
Contributor Author

@pierrehilbert yeah, I'm surprised that neither myself nor anyone reviewing it caught that in review, I usually look things over for superfluous debug statements. I wonder if the sonarqube tool can be set to worn us somehow?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Fleet]: Multiple logs: [elastic_agent][info] got checkin with pid 0 are generated for installed agent.
5 participants