feat(brush): show crosshair cursor when brush enabled #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #243 +/- ##
==========================================
+ Coverage 97.75% 97.75% +<.01%
==========================================
Files 36 36
Lines 2626 2632 +6
Branches 587 588 +1
==========================================
+ Hits 2567 2573 +6
Misses 52 52
Partials 7 7
Continue to review full report at Codecov.
|
markov00
pushed a commit
that referenced
this pull request
Jun 19, 2019
# [6.1.0](v6.0.1...v6.1.0) (2019-06-19) ### Features * **brush:** show crosshair cursor when brush enabled ([#243](#243)) ([0b44b87](0b44b87))
|
🎉 This PR is included in version 6.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
AMoo-Miki
pushed a commit
to AMoo-Miki/OpenSearch-Dashboards
that referenced
this pull request
Feb 10, 2022
# [6.1.0](elastic/elastic-charts@v6.0.1...v6.1.0) (2019-06-19) ### Features * **brush:** show crosshair cursor when brush enabled ([opensearch-project#243](elastic/elastic-charts#243)) ([30aff75](elastic/elastic-charts@30aff75))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the functionality that when
onBrushEndListeneris defined and the cursor is within the chart bounds (excluding the axes), the cursor will appear as a crosshair instead of the pointer or default.Notice below (from Kibana Discover) that the bottom version (the original implementation) has the crosshair cursor visible to indicate to the user that the brushing is possible, while in the top version (elastic-charts version), the cursor remains the default.
This PR adds a new computed method to the chart store that checks the cursor position and
isBrushEnabledto determine if the crosshair cursor should be visible.Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.- [ ] Any consumer-facing exports were added tosrc/index.ts(and stories only import from../srcexcept for test data & storybook)