-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(deps): update canvas to 2.8.0 #1367
build(deps): update canvas to 2.8.0 #1367
Conversation
Are there any cases where we would not want the full implementation and instead just want to mock out any canvas elements in unit tests? |
Probably in most cases, but the think is that the |
jenkins test this retrying due to failure on linking a c++ lib required by |
There are two possible solutions to the above-mentioned issue in Jenkins:
|
jenkins test this |
7148acf
to
604b153
Compare
@markov00 It seems to be using the
|
🎉 This PR is included in version 36.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
I've updated
canvas
dependency to 2.8.0 to fix a missing function Automattic/node-canvas#1769 and I've removedjest-canvas-mock
becausecanvas
already mocks everything we need.@monfera I've also tried the failing changes in https://github.com/elastic/elastic-charts/pull/1309/files replacing the
clearCanvas
method with:and it works correctly now