fix(metric): background color for bar with interactions #2248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickofthyme
added
bug
|
buildkite update screenshots |
|
buildkite update screenshots |
|
buildkite test this |
nickofthyme
added a commit
to nickofthyme/elastic-charts
that referenced
this pull request
Nov 19, 2023
# Conflicts: # e2e/screenshots/bullet_stories.test.ts-snapshots/bullet-stories/bullet-as-metric-horizontal/bullet-as-metric/should-render-with-negative-values-chrome-linux.png # e2e/screenshots/bullet_stories.test.ts-snapshots/bullet-stories/bullet-as-metric-horizontal/bullet-as-metric/should-render-with-negative-values-reversed-chrome-linux.png # e2e/screenshots/bullet_stories.test.ts-snapshots/bullet-stories/bullet-as-metric-horizontal/bullet-as-metric/should-render-with-positive-negative-values-chrome-linux.png # e2e/screenshots/bullet_stories.test.ts-snapshots/bullet-stories/bullet-as-metric-horizontal/bullet-as-metric/should-render-with-positive-negative-values-reversed-chrome-linux.png # e2e/screenshots/bullet_stories.test.ts-snapshots/bullet-stories/bullet-as-metric-horizontal/bullet-as-metric/should-render-with-positive-values-chrome-linux.png # e2e/screenshots/bullet_stories.test.ts-snapshots/bullet-stories/bullet-as-metric-horizontal/bullet-as-metric/should-render-with-positive-values-reversed-chrome-linux.png # e2e/screenshots/bullet_stories.test.ts-snapshots/bullet-stories/bullet-as-metric-two-thirds-circle/bullet-as-metric/should-render-with-negative-values-chrome-linux.png # e2e/screenshots/bullet_stories.test.ts-snapshots/bullet-stories/bullet-as-metric-two-thirds-circle/bullet-as-metric/should-render-with-negative-values-reversed-chrome-linux.png # e2e/screenshots/bullet_stories.test.ts-snapshots/bullet-stories/bullet-as-metric-two-thirds-circle/bullet-as-metric/should-render-with-positive-negative-values-chrome-linux.png # e2e/screenshots/bullet_stories.test.ts-snapshots/bullet-stories/bullet-as-metric-two-thirds-circle/bullet-as-metric/should-render-with-positive-negative-values-reversed-chrome-linux.png # e2e/screenshots/bullet_stories.test.ts-snapshots/bullet-stories/bullet-as-metric-two-thirds-circle/bullet-as-metric/should-render-with-positive-values-chrome-linux.png # e2e/screenshots/bullet_stories.test.ts-snapshots/bullet-stories/bullet-as-metric-two-thirds-circle/bullet-as-metric/should-render-with-positive-values-reversed-chrome-linux.png # e2e/screenshots/bullet_stories.test.ts-snapshots/bullet-stories/bullet-as-metric-vertical/bullet-as-metric/should-render-with-negative-values-chrome-linux.png # e2e/screenshots/bullet_stories.test.ts-snapshots/bullet-stories/bullet-as-metric-vertical/bullet-as-metric/should-render-with-negative-values-reversed-chrome-linux.png # e2e/screenshots/bullet_stories.test.ts-snapshots/bullet-stories/bullet-as-metric-vertical/bullet-as-metric/should-render-with-positive-negative-values-chrome-linux.png # e2e/screenshots/bullet_stories.test.ts-snapshots/bullet-stories/bullet-as-metric-vertical/bullet-as-metric/should-render-with-positive-negative-values-reversed-chrome-linux.png # e2e/screenshots/bullet_stories.test.ts-snapshots/bullet-stories/bullet-as-metric-vertical/bullet-as-metric/should-render-with-positive-values-chrome-linux.png # e2e/screenshots/bullet_stories.test.ts-snapshots/bullet-stories/bullet-as-metric-vertical/bullet-as-metric/should-render-with-positive-values-reversed-chrome-linux.png # packages/charts/src/chart_types/metric/renderer/dom/metric.tsx # packages/charts/src/chart_types/metric/renderer/dom/progress.tsx
nickofthyme
pushed a commit
that referenced
this pull request
Nov 20, 2023
# [61.1.0](v61.0.0...v61.1.0) (2023-11-20) ### Bug Fixes * **deps:** update dependency @elastic/eui to v91 ([#2233](#2233)) ([e89f623](e89f623)) * **metric:** add option to set empty cell background color ([#2247](#2247)) ([6a9fb86](6a9fb86)) * **metric:** background color for bar with interactions ([#2248](#2248)) ([dcb56fa](dcb56fa)) ### Features * **bullet:** improve header layout and positioning ([#2243](#2243)) ([b3a95d2](b3a95d2)) * **bullet:** new design style and implementation ([#2156](#2156)) ([fca6cdd](fca6cdd))
nickofthyme
pushed a commit
that referenced
this pull request
Nov 20, 2023
## [61.0.1](v61.0.0...v61.0.1) (2023-11-20) ### Bug Fixes * **metric:** add option to set empty cell background color ([#2247](#2247)) [61.0.x] ([#2250](#2250)) ([fe3aefe](fe3aefe)) * **metric:** background color for bar with interactions ([#2248](#2248)) [61.0.x] ([#2249](#2249)) ([4483606](4483606))
6 tasks
nickofthyme
added a commit
to nickofthyme/elastic-charts
that referenced
this pull request
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes changes made in #2184 with the interaction hover coloring for metrics with progress bar.
Before
After
Details
When adding support for transparent colors in #2184 we used the default
chartBackgroundcomponent to supply the background and have the browser blend the colors. However, these changes removed the interaction lightening affect on metrics with bar charts because this would simply set no background on the.echMetricso the background would show through. But without any color we cannot lighten it to render the interaction affect.closes #2246
Checklist
:xy,:partition):interactions,:axis)lightanddarkthemes