Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase coverage fix bugs #107

Merged
merged 11 commits into from
Apr 21, 2022
Merged

Conversation

aspacca
Copy link
Contributor

@aspacca aspacca commented Apr 19, 2022

Bug

What does this PR do?

Increase coverage of the whole codebase to 100%

Why is it important?

Extending the coverage to 100% avoided making assumptions on execution paths worth covering or not.
Aiming for 100% in a mix between unit and integration tests, we were able to assure nothing was missed because of "bias" on what was worth covering and what not, and indeed we spotted three bugs that we were able to fix:

  1. flushing in kinesis-data-stream input type
  2. empty messages in include exclude filters
  3. empty lines in JsonCollector decorator

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
    - [ ] I have made corresponding changes to the documentation
    - [ ] I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.md

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@aspacca aspacca self-assigned this Apr 19, 2022
@elasticmachine
Copy link

elasticmachine commented Apr 19, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-04-21T04:03:10.498+0000

  • Duration: 24 min 35 sec

Test stats 🧪

Test Results
Failed 0
Passed 65
Skipped 0
Total 65

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@aspacca aspacca merged commit 37995c0 into elastic:main Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants