You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is it true that this method can actually throw an IOException? I'd expect that the CompletableFuture might return a failure (essentially wrapping the exception), but it's not actually throwing said exception. Am I missing some other checked IOException further down in the call chain? In the above example, RestClientTransport#performRequestAsyncdoesn't throw an IOException.
The text was updated successfully, but these errors were encountered:
You're indeed right @MT-Jacobs, thanks for the catch. Neither IOException nor ElasticsearchException are actually thrown from async client methods. We'll remove them.
swallez
changed the title
IOExceptions on async client?
Async client methods should not declare exceptions
Jan 10, 2022
For my example, let's take a look at
ElasticsearchAsyncClient#index
:Is it true that this method can actually throw an IOException? I'd expect that the
CompletableFuture
might return a failure (essentially wrapping the exception), but it's not actually throwing said exception. Am I missing some other checkedIOException
further down in the call chain? In the above example,RestClientTransport#performRequestAsync
doesn't throw anIOException
.The text was updated successfully, but these errors were encountered: