fix: AttributeError: 'bytes' object has no attribute 'encode'(PY3) #652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please rebase off master and try again. I had to upgrade the version of ES Travis uses. |
|
@fxdgear Hi, I've done rebase and passed local tests with python version 2.7.14 and 3.6.2. Glad to know if you'd like to merge this. |
rciorba
added a commit
to rciorba/elasticsearch-py
that referenced
this pull request
Mar 2, 2018
fix: AttributeError: 'bytes' object has no attribute 'encode'(PY3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I had this error in python3.6.2 while using elasticsearch as backend of celery. So I tracked down the error message and come to a simple fix for this. It's working now in my local python3.6.2 virtualenv, and I guess this should work for all. I'd like to hear your comments :)