Update callbacks do not use as_indexed_json

[fcheung]

The update callbacks mine changed_attributes directly

def update_document(options={})
   if changed_attributes = self.instance_variable_get(:@__changed_attributes)
     client.update(
        { index: index_name,
          type:  document_type,
          id:    self.id,
          body:  { doc: changed_attributes } }.merge(options)
     )
  else
    index_document(options)
  end
end

This has 2 consequences for people with a custom as_indexed_json

• any indexed attributes that are not active model attributes are not indexed
• if as_indexed_json omits some attributes then they will be included when a record is updated in this way

Perhaps the documentation should highlight this?

[palanglung]

+1
the changed_attributes should filtered as like as_indexed_json cause maybe not all fields are public and used for indexing.

[fcheung]

If we did want to make this work beyond trivial cases perhaps ES::Model should be asking the instance for updates rather than taking them out of changed attributes. There could always be a default implementation that just returned the changed attributes.

On the otherhand perhaps the pragmatic thing is to just write your own update_document if you have that need.

[samqiu]

Please see #5 .

[fcheung]

D'oh - I'm a dummy. Given that the conclusion has been reached that the library shouldn't be trying to do anything smart in this case, perhaps the documentation should reflect this?

[spodlecki]

+1 to document it's behavior in README. I had custom callbacks, and it would not update the serialized json field. The solution was to just use es.index_document on the models that have serialized fields versus update_document. Its a bit of a performance killer most likely, but it works and is only updated on a cron job every 20 mins.

[karmi]

@fcheung I'm still thinking whether we can somehow intercept the changes better, but I don't think so. It would be nice to check whether the model itself (and not the proxy) implements the as_indexed_method...

[karmi]

@fcheung Actually, the simple case was quite simple to solve, unless I'm missing something very obvious -- please check the linked commit.