JRuby build #1258
Merged
JRuby build #1258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Extracts meta header related code into a module - Adds more tests for specific situations when http libraries haven't been loaded by the time the meta header methods are called Related to #1224
There's an issue with current versions of Typhoeus and libcurl, triggering a segmentation fault. I will update to rerun these tests once there's a fix.
picandocodigo
force-pushed
the
jruby_debug
branch
from
a74d9e0
to
4246ece
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current issue with the JRuby build is related to an error which involves Typhoeus and its interaction with native
libcurl. So I'mstopping the failing tests from Typhoeus from running in JRuby. I will research further and I will update once there's a proper fix for that issue.
While debugging the issue with the JRuby build, I found #1226 hadn't been ported to master so this PR also includes that code.