Fail with a better error when if there are no ingest nodes (#48272)

when executing enrich execute policy api.
elastic · Oct 22, 2019 · d172631 · d172631
1 parent 3f93300
commit d172631
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 0 deletions.
diff --git a/...c/main/java/org/elasticsearch/xpack/enrich/action/TransportExecuteEnrichPolicyAction.java b/...c/main/java/org/elasticsearch/xpack/enrich/action/TransportExecuteEnrichPolicyAction.java
@@ -62,6 +62,12 @@ protected ExecuteEnrichPolicyAction.Response read(StreamInput in) throws IOExcep
     @Override
     protected void masterOperation(ExecuteEnrichPolicyAction.Request request, ClusterState state,
                                    ActionListener<ExecuteEnrichPolicyAction.Response> listener) {
+        if (state.getNodes().getIngestNodes().isEmpty()) {
+            // if we don't fail here then reindex will fail with a more complicated error.
+            // (EnrichPolicyRunner uses a pipeline with reindex)
+            throw new IllegalStateException("no ingest nodes in this cluster");
+        }
+
         if (request.isWaitForCompletion()) {
             executor.runPolicy(request, new ActionListener<ExecuteEnrichPolicyStatus>() {
                 @Override

diff --git a/x-pack/plugin/enrich/src/test/java/org/elasticsearch/xpack/enrich/EnrichMultiNodeIT.java b/x-pack/plugin/enrich/src/test/java/org/elasticsearch/xpack/enrich/EnrichMultiNodeIT.java
@@ -134,6 +134,19 @@ public void testEnrichDedicatedIngestNode() {
         enrich(keys, ingestOnlyNode);
     }
 
+    public void testEnrichNoIngestNodes() {
+        Settings settings = Settings.builder()
+            .put(Node.NODE_MASTER_SETTING.getKey(), true)
+            .put(Node.NODE_DATA_SETTING.getKey(), true)
+            .put(Node.NODE_INGEST_SETTING.getKey(), false)
+            .build();
+        internalCluster().startNode(settings);
+
+        createSourceIndex(64);
+        Exception e = expectThrows(IllegalStateException.class, EnrichMultiNodeIT::createAndExecutePolicy);
+        assertThat(e.getMessage(), equalTo("no ingest nodes in this cluster"));
+    }
+
     private static void enrich(List<String> keys, String coordinatingNode) {
         int numDocs = 256;
         BulkRequest bulkRequest = new BulkRequest("my-index");