Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use underscores instead of camel-casing for date formats #12429

Closed
clintongormley opened this issue Jul 23, 2015 · 2 comments
Closed

Use underscores instead of camel-casing for date formats #12429

clintongormley opened this issue Jul 23, 2015 · 2 comments
Assignees
Labels
good first issue low hanging fruit help wanted adoptme :Search Foundations/Mapping Index mappings, including merging and defining field types Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch v2.0.0-beta1

Comments

@clintongormley
Copy link
Contributor

The date formats stand out as one of the few place we use camel casing, eg strictDateOptionalTime

These should be changed to strict_date_optional_time etc

@bookshelfdave
Copy link
Contributor

@clintongormley It looks like the formats have been updated in the Joda class already, is this simply changing tests and docs to reflect these changes?

@bookshelfdave bookshelfdave self-assigned this Jul 27, 2015
@clintongormley
Copy link
Contributor Author

@metadave It's the stringification which defaults to camelcase. Try:

PUT my_index/my_type/1
{
  "date": "2007-01-01T01:00:00Z"
}

GET my_index/_mapping

Don't worry about the docs, I'm reworking those in a bigger change

mute pushed a commit to mute/elasticsearch that referenced this issue Jul 29, 2015
@clintongormley clintongormley added :Search Foundations/Mapping Index mappings, including merging and defining field types and removed :Dates labels Feb 13, 2018
@javanna javanna added the Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch label Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue low hanging fruit help wanted adoptme :Search Foundations/Mapping Index mappings, including merging and defining field types Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch v2.0.0-beta1
Projects
None yet
Development

No branches or pull requests

3 participants