Skip to content

Conversation

s1monw
Copy link
Contributor

@s1monw s1monw commented Aug 18, 2015

this method is very confusing and if it's used it's likely the wrong thing
with respect to the actual bound / published address. This change discourages
it's use and removes all useage. It's replaced with the actual published address
most of the time.

This can cause very confusing output for instance from http://localhost:9200/_cat/shards

index shard prirep state   docs  store ip            node    
foo   1     r      STARTED    5  5.5kb 192.168.2.123 Jester  
foo   1     p      STARTED    5 10.7kb 192.168.2.123 Sunfire 
foo   4     p      STARTED    4  8.1kb 192.168.2.123 Jester  
foo   4     r      STARTED    4 10.6kb 192.168.2.123 Sunfire 
foo   2     p      STARTED    9 10.9kb 192.168.2.123 Jester  
foo   2     r      STARTED    9 13.5kb 192.168.2.123 Sunfire 
foo   3     r      STARTED    7 15.9kb 192.168.2.123 Jester  
foo   3     p      STARTED    7 15.9kb 192.168.2.123 Sunfire 
foo   0     p      STARTED    5 13.3kb 192.168.2.123 Jester  
foo   0     r      STARTED    5 10.7kb 192.168.2.123 Sunfire 

it show 192.168.2.123 which is simply wrong here we bound to 127.0.0.1 and published on 127.0.0.1 as well.

@s1monw s1monw added >bug :Distributed Coordination/Network Http and internode communication implementations v2.0.0 labels Aug 18, 2015
@rmuir
Copy link
Contributor

rmuir commented Aug 18, 2015

awesome, +1, thank you for cleaning this up and removing the confusion

this method is very confusing and if it's used it's likely the wrong thing
with respect to the actual bound / published address. This change discourages
it's use and removes all useage. It's replaced with the actual published address
most of the time.
@s1monw s1monw force-pushed the dont_use_getLocalHost branch from b9e1300 to 1e511ed Compare August 18, 2015 14:48
@s1monw s1monw merged commit 1e511ed into elastic:master Aug 18, 2015
@s1monw s1monw deleted the dont_use_getLocalHost branch August 18, 2015 15:23
@clintongormley clintongormley changed the title Remove usage or InetAddress#getLocalHost Remove usage of InetAddress#getLocalHost Aug 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>bug :Distributed Coordination/Network Http and internode communication implementations v2.0.0-beta1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants