-
Notifications
You must be signed in to change notification settings - Fork 24.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow plugin removal with full name, or represent plugin list differently #20668
Comments
For the record, this has been introduced by #18683 |
Discussed in FixItFriday and we felt that we should use the columnar output for the list command but not prepend the version with the plugin name, so the output would look like:
We should make sure this change is also made in kibana and logstash so the output is consistent across all three |
Sorry was not in FixItFriday today and missed that discussion. I wonder if we should be consistent with the |
@colings86 The reason we are here is because of #18683 which wanted a machine-readable format for this output. I'm not sure if the whitespace satisfies that request or not; I'm not sure if we, for example, enforce that the name and version do not contain spaces. We previously discussed #18683 in an earlier Fix-it-Friday; I was against that change because it's conflating a human-readable API with a machine-readable API. |
@jasontedor Ok, thanks for giving more background. I have removed adoptme and marks as discuss again as there is obviously more that we need to work out here before we implement/don't implement this change |
I also was against the change in #18683. I think it should be reverted. I dont' think we should complicate the plugin tool anymore. We have a verbose option for the extra information. As I explained in that issue, having the version does not actually help with "automating". When elasticsearch is upgraded, all plugins must be upgraded. |
Filing on behalf of @markwalkom
Elasticsearch version: 5.0.0-beta1
Plugins installed: x-pack
Description of the problem including expected versus actual behavior:
The output of the plugin list command can be counter-intuitive for users looking to remove a plugin:
Current Output:
Users should be able to remove plugins using the displayed, long name, ie
x-pack@5.0.0-beta1
, or we should have a columnar representation of the plugins like:The text was updated successfully, but these errors were encountered: