Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] GraphExplorer.testFromXContentWithFailures fails #33231

Closed
cbuescher opened this issue Aug 29, 2018 · 2 comments
Closed

[CI] GraphExplorer.testFromXContentWithFailures fails #33231

cbuescher opened this issue Aug 29, 2018 · 2 comments
Assignees
Labels
>test-failure Triaged test failures from CI

Comments

@cbuescher
Copy link
Member

Build: https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+6.x+multijob-unix-compatibility/os=fedora/1258/console

This reproduces locally for me with:

./gradlew :x-pack:plugin:core:test \
  -Dtests.seed=D6E662ED87F0B085 \
  -Dtests.class=org.elasticsearch.protocol.xpack.graph.GraphExploreResponseTests \
  -Dtests.method="testFromXContentWithFailures" \
  -Dtests.security.manager=true \
  -Dtests.locale=es-EC \
  -Dtests.timezone=America/Santiago \
  -Dcompiler.java=10 \
  -Druntime.java=8

Error:

FAILURE 1.61s | GraphExploreResponseTests.testFromXContentWithFailures <<< FAILURES!
   > Throwable #1: arrays first differed at element [90]; expected:<field1:wmDMD> but was:<field1:xGHbA>
   >    at __randomizedtesting.SeedInfo.seed([D6E662ED87F0B085:96929E5D4A35B194]:0)
   >    at org.elasticsearch.protocol.xpack.graph.GraphExploreResponseTests.assertEqualInstances(GraphExploreResponseTests.java:98)
   >    at org.elasticsearch.test.AbstractXContentTestCase.testFromXContent(AbstractXContentTestCase.java:61)
   >    at org.elasticsearch.protocol.xpack.graph.GraphExploreResponseTests.testFromXContentWithFailures(GraphExploreResponseTests.java:118)
   >    at java.lang.Thread.run(Thread.java:748)
   > Caused by: java.lang.AssertionError: expected:<field1:wmDMD> but was:<field1:xGHbA>
   >    ... 43 more

Looks quite similar to #33086 which should be fixed on 6.x. and master, this is another test method though. @markharwood Do you immediately see what is wrong here, since you already fixed a very similar looking issue? Otherwise I could also take a look at it.

@cbuescher cbuescher added >test-failure Triaged test failures from CI :Search/Graph labels Aug 29, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search-aggs

markharwood added a commit that referenced this issue Aug 29, 2018
markharwood added a commit that referenced this issue Aug 29, 2018
…y of GraphExploreResponseTests taken from protocol.

Related to #33231
@markharwood
Copy link
Contributor

In follow up tests porting this fix I discovered another variant with seed 57C56B8D4FCC8802

  • this seed randomises the "connections" array as opposed to the "vertices" array.
    I added "connections" to the list of fields that shouldn't be randomised in 6.x and master

markharwood added a commit that referenced this issue Aug 29, 2018
dnhatn added a commit that referenced this issue Aug 29, 2018
* 6.x:
  Fix forbidden apis on FIPS (#33202)
  HLRC: Add ML Get Records API (#33085)
  [ML] Fix character set finder bug with unencodable charsets (#33234)
  Tests fix - Graph HLRC client overly long line and syncing core’s copy of GraphExploreResponseTests taken from protocol. Related to #33231
  Test fix - Graph HLRC test was missing field name to be excluded from randomisation logic
  Parse PEM Key files leniantly (#33173)
  Core: Add java time xcontent serializers (#33120)
  Consider multi release jars when running third party audit (#33206)
  Update MSI documentation (#31950)
  [DOCS] Fixes command page titles
  HLRC: Move ML protocol classes into client ml package (#33203)
  Painless: Fix Semicolon Regression (#33212)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>test-failure Triaged test failures from CI
Projects
None yet
Development

No branches or pull requests

3 participants